Switch to using scoped_ptr with UserData

chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc

Index: chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc b/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc
index f7350eaf54709ae4c1eb2c77e5e15293de8efdc5..f5a1103bef7c95f8dc2c70591706a0ec26292cba 100644
--- a/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc
@@ -515,8 +515,8 @@ class RemoveDownloadsTester {
  public:
   explicit RemoveDownloadsTester(BrowserContext* browser_context)
       : download_manager_(new content::MockDownloadManager()) {
-    content::BrowserContext::SetDownloadManagerForTesting(browser_context,
-                                                          download_manager_);
+    content::BrowserContext::SetDownloadManagerForTesting(
+        browser_context, base::WrapUnique(download_manager_));

[Nico, 2017/04/14 15:46:58]

That looks really surprising, having a member owned by a thing that gets passed
in. At least add a comment to the member variable explaining this; ideally
reshuffle things to make ownership less weird.

[Avi (use Gerrit), 2017/04/14 18:17:50]

Done.

     EXPECT_EQ(download_manager_,
               content::BrowserContext::GetDownloadManager(browser_context));
     EXPECT_CALL(*download_manager_, Shutdown());