chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm - Issue 2815823003: Notify OverscrollController of gesture events in plugins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

Issue 2815823003: Notify OverscrollController of gesture events in plugins. (Closed)

Patch Set: Address comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | content/browser/frame_host/render_widget_host_view_child_frame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

diff --git a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

index ca8813508c85ed2c8627a4db5a416f9eb8ad4c6c..ccb342db85e495740bb28dc4488526c80877458d 100644

--- a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

+++ b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm

@@ -131,6 +131,14 @@ BOOL forceMagicMouse = NO;

blink::WebGestureEvent::kMomentumPhase) {

return;

}

+ // GestureScrollBegin and GestureScrollEnd events are created to wrap

+ // individual resent GestureScrollUpdates from a plugin. Hence these

+ // should not be used to indicate the beginning/end of the swipe gesture.

+ // TODO(mcnee): When we remove BrowserPlugin, delete this code.

+ // See crbug.com/533069

+ if (event.resending_plugin_id != -1) {

+ return;

+ }

waitingForFirstGestureScroll_ = YES;

break;

case blink::WebInputEvent::kGestureScrollUpdate: