Notify OverscrollController of gesture events in plugins.

content/public/test/browser_test_utils.h

Index: content/public/test/browser_test_utils.h
diff --git a/content/public/test/browser_test_utils.h b/content/public/test/browser_test_utils.h
index 4122a90711a5abfdb751c244b17710fe53460231..e64b53f7d133de41d3eea19c80bb73ea6d7c918e 100644
--- a/content/public/test/browser_test_utils.h
+++ b/content/public/test/browser_test_utils.h
@@ -850,6 +850,23 @@ class PwnMessageHelper {
   DISALLOW_COPY_AND_ASSIGN(PwnMessageHelper);
 };
 
+#if defined(USE_AURA)
+// Wraps an OverscrollController so we can inspect the scroll events that it
+// receives.
+// TODO(mcnee): Tests needing this are BrowserPlugin specific
+// (crbug.com/533069).

[Charlie Reis, 2017/05/30 22:35:17]

I don't understand this TODO.  Can you rephrase it to reflect what the action
should be?  (I'm not sure if it should be removed when BrowserPlugin is removed,
or if it's saying that it should be used in OOPIF-based guest tests in the
future as well.)

[Kevin McNee, 2017/05/31 18:07:35]

Done.

+class OverscrollControllerSpy {

[Charlie Reis, 2017/05/30 22:35:17]

Is spy a design pattern?  I don't many instances of it in the code, so I'm
curious about the choice of name.  Maybe it's worth mentioning something about
it in the comment if more common names like Observer aren't the right fit.

[Kevin McNee, 2017/05/31 18:07:35]

It's essentially a partial mock. We're inspecting the calls to a real
implementation rather than an interface. I've changed the name to a mock and
made note of this in a comment.

+ public:
+  // Creates a spy and installs it on the given RenderWidgetHostViewAura.
+  // The returned spy is owned by the RWHVA.
+  static OverscrollControllerSpy* Create(RenderWidgetHostView* rwhv);
+
+  virtual ~OverscrollControllerSpy() {}
+
+  virtual void WaitForScrollStateContentScrolling() = 0;

[Charlie Reis, 2017/05/30 22:35:17]

Needs a comment.

[Kevin McNee, 2017/05/31 18:07:35]

Done.

+};
+#endif  // defined(USE_AURA)
+
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_TEST_BROWSER_TEST_UTILS_H_