third_party/WebKit/LayoutTests/fast/dom/Range/insertNode-trigger-onpageshow-crash.html - Issue 2815803003: Make Pageshow event asynchronous in EventQueueScope

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/Range/insertNode-trigger-onpageshow-crash.html

Issue 2815803003: Make Pageshow event asynchronous in EventQueueScope (Closed)

Patch Set: Delete unnecessary change Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	yosin_UTC9 2017/04/13 00:56:16 Could you use gTest instead of layout test to veri Could you use gTest instead of layout test to verify we defer "pageshow" event? Instead of indirectly checking it? For example: TEST_F(...) { ... build HTML ... ... install event handler to check "pageshow" event dispatched after ScopedEventQueue ... { ScopedEventQueue scope; ... dispatch "pageshow" event ... EXPECT_TRUE(... scope has queued "pageshow" event" ...) } EXPECT_TRUE(... "pageshow" event dispatched ... "); }
	2 <script src='../../../resources/testharness.js'></script>

	3 <script src='../../../resources/testharnessreport.js'></script>

	4 <audio src="aOyer">

	5 <script>

	6 const audio = document.querySelector('audio');

	7 const newNode = document.createElement('frame');

	8

	9 function handler(event) {

	10 document.body.webkitRequestFullscreen();

	11 var range = document.createRange();

	12 range.setStartBefore(audio);

	13 range.insertNode(newNode);

	14 range.deleteContents();

	15 }

	16

	17 test(() => {

	18 window.onpageshow = handler;

	19 document.onwebkitfullscreenerror = handler;

	20 audio.onloadstart = handler;

	21 assert_true(true, 'This test must run without crash.');

	22 }, 'range.insertNode() should not call onpageshow event synchronously (crbug.c om/660269).' );

	23 </script>

OLD	NEW