Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: components/payments/core/payment_request_data_util.cc

Issue 2815763002: Prevent usage of web payments API over insecure HTTPS. (Closed)
Patch Set: Ganggui's comment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/payments/core/payment_request_data_util.cc
diff --git a/components/payments/core/payment_request_data_util.cc b/components/payments/core/payment_request_data_util.cc
index 8fb6572312222574f9e3c93a5244aca9dfe42716..9a5f5f4f9636f30dc2b60ac6423a53d4a92ff5c3 100644
--- a/components/payments/core/payment_request_data_util.cc
+++ b/components/payments/core/payment_request_data_util.cc
@@ -95,7 +95,7 @@ BasicCardResponse GetBasicCardResponseFromAutofillCreditCard(
return response;
}
-bool ParseBasicCardSupportedNetworks(
+void ParseBasicCardSupportedNetworks(
const std::vector<PaymentMethodData>& method_data,
std::vector<std::string>* out_supported_networks,
std::set<std::string>* out_basic_card_specified_networks) {
@@ -107,7 +107,7 @@ bool ParseBasicCardSupportedNetworks(
"unionpay", "visa"};
for (const PaymentMethodData& method_data_entry : method_data) {
if (method_data_entry.supported_methods.empty())
- return false;
+ return;
for (const std::string& method : method_data_entry.supported_methods) {
if (method.empty())
@@ -153,7 +153,6 @@ bool ParseBasicCardSupportedNetworks(
}
}
}
- return true;
}
std::string FormatPhoneForDisplay(const std::string& phone_number,

Powered by Google App Engine
This is Rietveld 408576698