Prevent usage of web payments API over insecure HTTPS.

chrome/browser/ui/views/payments/payment_request_browsertest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/views/payments/payment_request_browsertest_base.h"
@@ skipping 20 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(PaymentRequestWebContentsManagerTest);
 };
 
 // If the page creates multiple PaymentRequest objects, it should not crash.
 IN_PROC_BROWSER_TEST_F(PaymentRequestWebContentsManagerTest, MultipleRequests) {
   const std::vector<PaymentRequest*> payment_requests =
       GetPaymentRequests(GetActiveWebContents());
   EXPECT_EQ(5U, payment_requests.size());
 }
 
 class PaymentRequestNoShippingTest : public PaymentRequestBrowserTestBase {

[Mathieu, 2017/04/17 03:20:45]

Do you think we could have a test that tries to show the UI on an page with
invalid ssl? See my other comment in can_make_payment_browsertest about how to
achieve this with the test delegate

[please use gerrit instead, 2017/04/17 18:19:54]

Done.

  protected:
   PaymentRequestNoShippingTest()
       : PaymentRequestBrowserTestBase(
             "/payment_request_no_shipping_test.html") {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PaymentRequestNoShippingTest);
 };
 
 IN_PROC_BROWSER_TEST_F(PaymentRequestNoShippingTest, OpenAndNavigateTo404) {
@@ skipping 59 matching lines @@
 
   InvokePaymentRequestUI();
 
   ResetEventObserver(DialogEvent::DIALOG_CLOSED);
 
   PayWithCreditCardAndWait(base::ASCIIToUTF16("123"));
 
   WaitForObservedEvent();
 
   // The actual structure of the card response is unit-tested.
-  ExpectBodyContains(std::vector<base::string16>{
-      card.GetRawInfo(autofill::CREDIT_CARD_NUMBER),
-      card.GetRawInfo(autofill::CREDIT_CARD_NAME_FULL),
-      card.GetRawInfo(autofill::CREDIT_CARD_EXP_MONTH),
-      card.GetRawInfo(autofill::CREDIT_CARD_EXP_4_DIGIT_YEAR)});
-  ExpectBodyContains(std::vector<base::string16>{
-      billing_address.GetRawInfo(autofill::NAME_FIRST),
-      billing_address.GetRawInfo(autofill::NAME_LAST),
-      billing_address.GetRawInfo(autofill::ADDRESS_HOME_LINE1),
-      billing_address.GetRawInfo(autofill::ADDRESS_HOME_LINE2),
-      billing_address.GetRawInfo(autofill::ADDRESS_HOME_COUNTRY),
-      billing_address.GetRawInfo(autofill::ADDRESS_HOME_ZIP),
-      billing_address.GetRawInfo(autofill::ADDRESS_HOME_CITY),
-      billing_address.GetRawInfo(autofill::ADDRESS_HOME_STATE)});
+  ExpectBodyContains({card.GetRawInfo(autofill::CREDIT_CARD_NUMBER),
+                      card.GetRawInfo(autofill::CREDIT_CARD_NAME_FULL),
+                      card.GetRawInfo(autofill::CREDIT_CARD_EXP_MONTH),
+                      card.GetRawInfo(autofill::CREDIT_CARD_EXP_4_DIGIT_YEAR)});
+  ExpectBodyContains(
+      {billing_address.GetRawInfo(autofill::NAME_FIRST),
+       billing_address.GetRawInfo(autofill::NAME_LAST),
+       billing_address.GetRawInfo(autofill::ADDRESS_HOME_LINE1),
+       billing_address.GetRawInfo(autofill::ADDRESS_HOME_LINE2),
+       billing_address.GetRawInfo(autofill::ADDRESS_HOME_COUNTRY),
+       billing_address.GetRawInfo(autofill::ADDRESS_HOME_ZIP),
+       billing_address.GetRawInfo(autofill::ADDRESS_HOME_CITY),
+       billing_address.GetRawInfo(autofill::ADDRESS_HOME_STATE)});
 }
 
 class PaymentRequestAbortTest : public PaymentRequestBrowserTestBase {
  protected:
   PaymentRequestAbortTest()
       : PaymentRequestBrowserTestBase("/payment_request_abort_test.html") {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PaymentRequestAbortTest);
 };
@@ skipping 150 matching lines @@
   EXPECT_EQ(1u, requests.size());
   std::vector<std::string> supported_card_networks =
       requests[0]->spec()->supported_card_networks();
   EXPECT_EQ(3u, supported_card_networks.size());
   EXPECT_EQ("mastercard", supported_card_networks[0]);
   EXPECT_EQ("visa", supported_card_networks[1]);
   EXPECT_EQ("jcb", supported_card_networks[2]);
 }
 
 }  // namespace payments