Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h

Issue 2815733003: cros: Add PinStorageProvider enum which describes pin backend in use. (Closed)
Patch Set: Initial upload Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h
diff --git a/chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h b/chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h
index 8508fe469e882614532f3b1ea71591f5f3f8e9ff..7c01d00565f292ec25f4113d2985147753f0de16 100644
--- a/chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h
+++ b/chrome/browser/chromeos/login/quick_unlock/quick_unlock_utils.h
@@ -36,11 +36,17 @@ void RegisterProfilePrefs(PrefRegistrySimple* registry);
// flag is present.
bool IsPinEnabled(PrefService* pref_service);
+// What subsystem should provide pin storage and authentication?
+enum class PinStorageProvider { Prefs, Cryptohome };
achuithb 2017/04/17 22:04:12 newline after this line. Is there a better name?
+// Returns the pin storage provider that should be used. IsPinEnabled() must
+// return true for this result to be valid.
+PinStorageProvider GetPinStorageProvider();
+
// Returns true if the fingerprint unlock feature flag is present.
bool IsFingerprintEnabled();
-// Forcibly enable quick-unlock for testing.
-void EnableForTesting();
+// Forcibly enable all quick-unlock modes for testing.
+void EnableForTesting(PinStorageProvider pin_storage_provider);
} // namespace quick_unlock
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698