Issue 29109. Resynthesize PrefixElement(s) to fix constants evaluation.

Issue 29109. Resynthesize PrefixElement(s) to fix constants evaluation.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/29109

Committed: https://github.com/dart-lang/sdk/commit/38e8b1509e8c983cd454c86d1f10561dc0de1ae0

[Brian Wilkerson, 2017-04-11 18:16:35]

lgtm

https://codereview.chromium.org/2815713003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/element_text.dart (right):

https://codereview.chromium.org/2815713003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/element_text.dart:810: if (components.length > 1)
{
Shouldn't this be ">= 1"? (and similarly on line 813) It probably never matters
because we're probably never passing in a LibraryElement, but...

[Paul Berry, 2017-04-11 18:21:52]

lgtm

[scheglov, 2017-04-11 18:27:13]

https://codereview.chromium.org/2815713003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/element_text.dart (right):

https://codereview.chromium.org/2815713003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/element_text.dart:810: if (components.length > 1)
{
On 2017/04/11 18:16:35, Brian Wilkerson wrote:
> Shouldn't this be ">= 1"? (and similarly on line 813) It probably never
matters
> because we're probably never passing in a LibraryElement, but...

Yes, I think you're right, it's cleaner to check for only what we really use.
Fixed.

[scheglov, 2017-04-11 18:28:10]

Description was changed from

==========
Issue 29109. Resynthesize PrefixElement(s) to fix constants evaluation.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/29109
==========

to

==========
Issue 29109. Resynthesize PrefixElement(s) to fix constants evaluation.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/29109

Committed:
https://github.com/dart-lang/sdk/commit/38e8b1509e8c983cd454c86d1f10561dc0de1ae0
==========

[scheglov, 2017-04-11 18:28:11]

Committed patchset #1 (id:1) manually as
38e8b1509e8c983cd454c86d1f10561dc0de1ae0 (presubmit successful).