Disable collection backing reallocation during pre finalizer

third_party/WebKit/Source/platform/heap/HeapAllocator.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef HeapAllocator_h
 #define HeapAllocator_h
 
 #include "platform/heap/Heap.h"
 #include "platform/heap/Persistent.h"
 #include "platform/heap/TraceTraits.h"
@@ skipping 130 matching lines @@
 
   template <typename T>
   static void* NewArray(size_t bytes) {
     ASSERT_NOT_REACHED();
     return 0;
   }
 
   static void DeleteArray(void* ptr) { ASSERT_NOT_REACHED(); }
 
   static bool IsAllocationAllowed() {
-    return ThreadState::Current()->IsAllocationAllowed();
+    return ThreadState::Current()->IsAllocationAllowed() &&
+           !ThreadState::Current()->IsObjectRessurectionForbidden();

[haraken, 2017/04/12 11:03:37]

Hmm, it looks confusing to change the meaning of IsAllocationAllowed here. I'd
prefer separating the two methods.

I'm wondering if we can remove NoAllocationScope somehow. For example, the
NoAllocationScope in CollectGarbage wouldn't be needed since we can check if
we're in a GC or not by isInGC().

[keishi, 2017/04/13 05:22:42]

I added a separate method on Allocator.

Looks like we may able to remove it but leaving NoAllocationScope as is for this
CL.

   }
 
   template <typename T>
   static bool IsHeapObjectAlive(T* object) {
     return ThreadHeap::IsHeapObjectAlive(object);
   }
 
   template <typename VisitorDispatcher>
   static void MarkNoTracing(VisitorDispatcher visitor, const void* t) {
     visitor->MarkNoTracing(t);
@@ skipping 680 matching lines @@
     const blink::HeapHashCountedSet<Value, HashFunctions, Traits>& set,
     VectorType& vector) {
   CopyToVector(static_cast<const HashCountedSet<Value, HashFunctions, Traits,
                                                 blink::HeapAllocator>&>(set),
                vector);
 }
 
 }  // namespace WTF
 
 #endif