components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/EventConstants.java - Issue 2815653003: IPH - connect data saver previews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/EventConstants.java

Issue 2815653003: IPH - connect data saver previews (Closed)

Patch Set: Moved event tracking to the IPH infobar support Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/previews/previews_infobar_tab_helper.cc ('K') | « components/feature_engagement_tracker/internal/feature_list.cc ('k') | components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/FeatureConstants.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/EventConstants.java

diff --git a/components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/EventConstants.java b/components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/EventConstants.java

index 0f94cd801903eb5fd6ddc4fea6b3b384b5237464..8990e27778d7bd8cc9a7ba5864ab9f91cf6a0ec2 100644

--- a/components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/EventConstants.java

+++ b/components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/EventConstants.java

@@ -29,6 +29,11 @@ public final class EventConstants {

public static final String DOWNLOAD_HOME_OPENED = "download_home_opened";

/**

+ * The data server preview infobar was shown.

nyquist 2017/04/27 05:47:17 Nit: s/server/saver/

David Trainor- moved to gerrit 2017/04/28 00:57:46 It was supposed to be server (the server-side prev

+ */

+ public static final String DATA_SAVER_PREVIEW_INFOBAR_SHOWN = "data_saver_preview_opened";

+ /**

* Do not instantiate.

private EventConstants() {}