Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4050)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 2815653003: IPH - connect data saver previews (Closed)
Patch Set: Addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
index f7849b73c09e5908207e07b9c202ee851c838711..77ab29e38797e83adc7a00029a766868d828018a 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
@@ -31,6 +31,7 @@ import org.chromium.chrome.browser.infobar.AppBannerInfoBarDelegateAndroid;
import org.chromium.chrome.browser.infobar.InfoBar;
import org.chromium.chrome.browser.infobar.InfoBarContainer;
import org.chromium.chrome.browser.infobar.InfoBarContainer.InfoBarAnimationListener;
+import org.chromium.chrome.browser.infobar.InfoBarContainerLayout.Item;
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.webapps.WebappDataStorage;
@@ -162,6 +163,9 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
mDoneAnimating = true;
}
}
+
+ @Override
+ public void notifyAllAnimationsFinished(Item frontInfoBar) {}
}
private MockAppDetailsDelegate mDetailsDelegate;
@@ -257,7 +261,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
resetEngagementForUrl(url, 10);
InfoBarContainer container = getActivity().getActivityTab().getInfoBarContainer();
final InfobarListener listener = new InfobarListener();
- container.setAnimationListener(listener);
+ container.addAnimationListener(listener);
new TabLoadObserver(getActivity().getActivityTab()).fullyLoadUrl(url, PageTransition.TYPED);
waitUntilAppDetailsRetrieved(1);
assertEquals(mDetailsDelegate.mReferrer, expectedReferrer);
@@ -324,7 +328,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
// Add the animation listener in.
InfoBarContainer container = getActivity().getActivityTab().getInfoBarContainer();
final InfobarListener listener = new InfobarListener();
- container.setAnimationListener(listener);
+ container.addAnimationListener(listener);
// Update engagement, then revisit the page to get the banner to appear.
resetEngagementForUrl(url, 10);
@@ -442,7 +446,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
resetEngagementForUrl(mNativeAppUrl, 10);
InfoBarContainer container = getActivity().getActivityTab().getInfoBarContainer();
final InfobarListener listener = new InfobarListener();
- container.setAnimationListener(listener);
+ container.addAnimationListener(listener);
new TabLoadObserver(getActivity().getActivityTab())
.fullyLoadUrl(mNativeAppUrl, PageTransition.TYPED);
waitUntilAppDetailsRetrieved(1);
@@ -490,7 +494,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
resetEngagementForUrl(mWebAppUrl, 10);
InfoBarContainer container = getActivity().getActivityTab().getInfoBarContainer();
final InfobarListener listener = new InfobarListener();
- container.setAnimationListener(listener);
+ container.addAnimationListener(listener);
new TabLoadObserver(getActivity().getActivityTab())
.fullyLoadUrl(mWebAppUrl, PageTransition.TYPED);
waitUntilAppBannerInfoBarAppears(WEB_APP_TITLE);

Powered by Google App Engine
This is Rietveld 408576698