Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: chrome/browser/previews/previews_infobar_tab_helper.cc

Issue 2815653003: IPH - connect data saver previews (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/previews/previews_infobar_tab_helper.cc
diff --git a/chrome/browser/previews/previews_infobar_tab_helper.cc b/chrome/browser/previews/previews_infobar_tab_helper.cc
index 917d3ebfe75f971b74c06c06e12e3d47bda40eee..7904b0ba50e13b26fcaa7705474bd2dc77a297b6 100644
--- a/chrome/browser/previews/previews_infobar_tab_helper.cc
+++ b/chrome/browser/previews/previews_infobar_tab_helper.cc
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
+#include "chrome/browser/feature_engagement_tracker/feature_engagement_tracker_factory.h"
#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"
#include "chrome/browser/previews/previews_infobar_delegate.h"
@@ -14,6 +15,7 @@
#include "chrome/browser/profiles/profile.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h"
#include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"
+#include "components/feature_engagement_tracker/public/feature_engagement_tracker.h"
#include "components/previews/core/previews_experiments.h"
#include "components/previews/core/previews_ui_service.h"
#include "content/public/browser/browser_context.h"
@@ -29,6 +31,8 @@
namespace {
+const char kIPHDataSaverPreviewEvent[] = "Event_DataSaverPreview";
+
// Adds the preview navigation to the black list. This method is only used on
// android currently.
void AddPreviewNavigationCallback(content::BrowserContext* browser_context,
@@ -75,6 +79,12 @@ void PreviewsInfoBarTabHelper::DidFinishNavigation(
// TODO(ryansturm): Add UMA for errors.
return;
}
+
+ feature_engagement_tracker::FeatureEngagementTracker* tracker =
+ FeatureEngagementTrackerFactory::GetInstance()->GetForBrowserContext(
+ web_contents()->GetBrowserContext());
+ tracker->NotifyEvent(kIPHDataSaverPreviewEvent);
+
data_reduction_proxy::DataReductionProxySettings*
data_reduction_proxy_settings =
DataReductionProxyChromeSettingsFactory::GetForBrowserContext(

Powered by Google App Engine
This is Rietveld 408576698