IPH - connect data saver previews

chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.infobar;
 
 import android.content.Context;
 import android.view.Gravity;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.FrameLayout;
 
 import org.chromium.base.ObserverList;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.banners.SwipableOverlayView;
+import org.chromium.chrome.browser.infobar.InfoBarContainerLayout.Item;
 import org.chromium.chrome.browser.tab.EmptyTabObserver;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.browser.tab.TabObserver;
 import org.chromium.content.browser.ContentViewCore;
 import org.chromium.content_public.browser.WebContents;
 import org.chromium.ui.UiUtils;
 import org.chromium.ui.base.DeviceFormFactor;
 
 import java.util.ArrayList;
 
@@ skipping 22 matching lines @@
      */
     public interface InfoBarAnimationListener {
         public static final int ANIMATION_TYPE_SHOW = 0;
         public static final int ANIMATION_TYPE_SWAP = 1;
         public static final int ANIMATION_TYPE_HIDE = 2;
 
         /**
          * Notifies the subscriber when an animation is completed.
          */
         void notifyAnimationFinished(int animationType);
+
+        /**
+         * Notifies the subscriber when all animations are finished.
+         * @param frontInfoBar The frontmost infobar or {@code null} if none are showing.
+         */
+        void notifyAllAnimationsFinished(Item frontInfoBar);
     }
 
     /**
      * An observer that is notified of changes to a {@link InfoBarContainer} object.
      */
     public interface InfoBarContainerObserver {
         /**
          * Called when an {@link InfoBar} is about to be added (before the animation).
          * @param container The notifying {@link InfoBarContainer}
          * @param infoBar An {@link InfoBar} being added
@@ skipping 53 matching lines @@
         }
 
         @Override
         public void onViewAttachedToWindow(View v) {
             addToParentView();
         }
     };
 
     private final InfoBarContainerLayout mLayout;
 
+    private final IPHInfoBarSupport mIPHSupport;

[gone, 2017/04/18 21:05:19]

javadoc?

[David Trainor- moved to gerrit, 2017/04/25 05:01:05]

Done.

+
     /** Native InfoBarContainer pointer which will be set by nativeInit(). */
     private final long mNativeInfoBarContainer;
 
     /** The list of all InfoBars in this container, regardless of whether they've been shown yet. */
     private final ArrayList<InfoBar> mInfoBars = new ArrayList<InfoBar>();
 
     /** True when this container has been emptied and its native counterpart has been destroyed. */
     private boolean mDestroyed;
 
     /** Parent view that contains the InfoBarContainerLayout. */
@@ skipping 23 matching lines @@
                 ? TOP_MARGIN_TABLET_DP : TOP_MARGIN_PHONE_DP;
         lp.topMargin = Math.round(topMarginDp * getResources().getDisplayMetrics().density);
         setLayoutParams(lp);
 
         mParentView = parentView;
 
         mLayout = new InfoBarContainerLayout(context);
         addView(mLayout, new FrameLayout.LayoutParams(LayoutParams.MATCH_PARENT,
                 LayoutParams.WRAP_CONTENT, Gravity.CENTER_HORIZONTAL));
 
+        mIPHSupport = new IPHInfoBarSupport(context);
+        mLayout.addAnimationListener(mIPHSupport);
+        addObserver(mIPHSupport);
+
         // Chromium's InfoBarContainer may add an InfoBar immediately during this initialization
         // call, so make sure everything in the InfoBarContainer is completely ready beforehand.
         mNativeInfoBarContainer = nativeInit();
     }
 
     /**
      * Adds an {@link InfoBarContainerObserver}.
      * @param observer The {@link InfoBarContainerObserver} to add.
      */
     public void addObserver(InfoBarContainerObserver observer) {
@@ skipping 19 matching lines @@
     /**
      * Sets the parent {@link ViewGroup} that contains the {@link InfoBarContainer}.
      */
     public void setParentView(ViewGroup parent) {
         mParentView = parent;
         removeFromParentView();
         addToParentView();
     }
 
     @VisibleForTesting
     public void setAnimationListener(InfoBarAnimationListener listener) {

[gone, 2017/04/18 21:05:19]

rename the function?  set implies one

[David Trainor- moved to gerrit, 2017/04/25 05:01:05]

Done.

-        mLayout.setAnimationListener(listener);
+        mLayout.addAnimationListener(listener);
     }
 
     /**
      * Returns true if any animations are pending or in progress.
      */
     @VisibleForTesting
     public boolean isAnimating() {
         return mLayout.isAnimating();
     }
 
@@ skipping 64 matching lines @@
 
     /**
      * @return True when this container has been emptied and its native counterpart has been
      *         destroyed.
      */
     public boolean hasBeenDestroyed() {
         return mDestroyed;
     }
 
     public void destroy() {
+        mLayout.removeAnimationListener(mIPHSupport);
+        removeObserver(mIPHSupport);
         mDestroyed = true;
         if (mNativeInfoBarContainer != 0) {
             nativeDestroy(mNativeInfoBarContainer);
         }
     }
 
     /**
      * @return all of the InfoBars held in this container.
      */
     @VisibleForTesting
@@ skipping 80 matching lines @@
         }
 
         super.onLayout(changed, l, t, r, b);
     }
 
     private native long nativeInit();
     private native void nativeSetWebContents(
             long nativeInfoBarContainerAndroid, WebContents webContents);
     private native void nativeDestroy(long nativeInfoBarContainerAndroid);
 }