IPH - connect data saver previews

chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.infobar;
 
 import android.content.Context;
+import android.support.annotation.StringRes;
 import android.view.Gravity;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.FrameLayout;
 
 import org.chromium.base.ObserverList;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.banners.SwipableOverlayView;
+import org.chromium.chrome.browser.feature_engagement_tracker.FeatureEngagementTrackerFactory;
+import org.chromium.chrome.browser.profiles.Profile;
 import org.chromium.chrome.browser.tab.EmptyTabObserver;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.browser.tab.TabObserver;
+import org.chromium.chrome.browser.widget.textbubble.ViewAnchoredTextBubble;
+import org.chromium.components.feature_engagement_tracker.FeatureConstants;
+import org.chromium.components.feature_engagement_tracker.FeatureEngagementTracker;
 import org.chromium.content.browser.ContentViewCore;
 import org.chromium.content_public.browser.WebContents;
 import org.chromium.ui.UiUtils;
 import org.chromium.ui.base.DeviceFormFactor;
 
 import java.util.ArrayList;
 
 
 /**
  * A container for all the infobars of a specific tab.
@@ skipping 219 matching lines @@
 
         // We add the infobar immediately to mInfoBars but we wait for the animation to end to
         // notify it's been added, as tests rely on this notification but expects the infobar view
         // to be available when they get the notification.
         mInfoBars.add(infoBar);
         infoBar.setContext(getContext());
         infoBar.setInfoBarContainer(this);
         infoBar.createView();
 
         mLayout.addInfoBar(infoBar);
+
+        showFeatureEngagementForInfoBar(infoBar);

[David Trainor- moved to gerrit, 2017/04/12 08:41:20]

Hmm this doesn't mean the infobar is showing.  Would it make sense to have a way
to listen to the layout for when infobars become visible (I could also listen to
the view?)?

[gone, 2017/04/12 17:12:44]

Maybe see when InfoBarAnimationListener fires?

     }
 
     /**
      * Notifies that an infobar's View ({@link InfoBar#getView}) has changed. If the infobar is

[David Trainor- moved to gerrit, 2017/04/12 08:41:20]

So in this case I guess the iph would just get dismissed... I think that's ok. 
I can try to test this scenario out tomorrow night.

[gone, 2017/04/12 17:12:44]

Maybe.  This might happen when something like translate is going through
multiple phases, which means it's probably fine to dismiss the IPH anyway?

      * visible, a view swapping animation will be run.
      */
     public void notifyInfoBarViewChanged() {
         assert !mDestroyed;
         mLayout.notifyInfoBarViewChanged();
     }
 
     /**
      * Called by {@link InfoBar} to remove itself from the view hierarchy.
      *
      * @param infoBar InfoBar to remove from the View hierarchy.
      */
     void removeInfoBar(InfoBar infoBar) {
         assert !mDestroyed;
 
         if (!mInfoBars.remove(infoBar)) {
             assert false : "Trying to remove an InfoBar that is not in this container.";
             return;
         }
 
         // Notify observers immediately, before any animations begin.
         for (InfoBarContainerObserver observer : mObservers) {
             observer.onRemoveInfoBar(this, infoBar, mInfoBars.isEmpty());
         }
 
         mLayout.removeInfoBar(infoBar);
     }
 
+    private void showFeatureEngagementForInfoBar(InfoBar infoBar) {
+        String feature = null;
+        @StringRes
+        int text = 0;
+        switch (infoBar.getInfoBarIdentifier()) {
+            case InfoBarIdentifier.DATA_REDUCTION_PROXY_PREVIEW_INFOBAR_DELEGATE:
+                feature = FeatureConstants.DATA_SAVER_PREVIEW;
+                text = R.string.iph_data_saver_preview_text;
+                break;
+        }
+
+        if (feature == null) return;
+
+        Profile profile = Profile.getLastUsedProfile();
+        final FeatureEngagementTracker tracker =
+                FeatureEngagementTrackerFactory.getFeatureEngagementTrackerForProfile(profile);
+        if (!tracker.shouldTriggerHelpUI(feature)) return;
+
+        ViewAnchoredTextBubble bubble =
+                new ViewAnchoredTextBubble(getContext(), infoBar.getView(), text);
+        bubble.setDismissOnTouchInteraction(true);
+        bubble.setOnDismissListener(new OnDismissListener() {
+            @Override
+            public void onDismiss() {
+                tracker.dismissed();
+            }
+        });
+        bubble.show();
+    }
+
     /**
      * @return True when this container has been emptied and its native counterpart has been
      *         destroyed.
      */
     public boolean hasBeenDestroyed() {
         return mDestroyed;
     }
 
     public void destroy() {
         mDestroyed = true;
@@ skipping 89 matching lines @@
         }
 
         super.onLayout(changed, l, t, r, b);
     }
 
     private native long nativeInit();
     private native void nativeSetWebContents(
             long nativeInfoBarContainerAndroid, WebContents webContents);
     private native void nativeDestroy(long nativeInfoBarContainerAndroid);
 }