Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issue 2815643004: Temp fix to allow plugins to serve the getErrors APIs. (Closed)

Created:
3 years, 8 months ago by mfairhurst
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Temp fix to allow plugins to serve the getErrors APIs. Had to allow a means of supplementing existing errors/line info, but then also for where dart has no response whatsoever (like html), need a way to provide analysis options and line info in addition to errors. Happy to clean it up, but also not very motivated to make it perfect since it should be temporary. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/d55dc297279810babb84747c19937b3fe23acb8c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mfairhurst
Temporary fix is enablement for: https://github.com/dart-lang/angular_analyzer_plugin/pull/273 This is required for cider and for vim integration, ...
3 years, 8 months ago (2017-04-11 21:57:40 UTC) #1
mfairhurst
Temporary fix is enablement for: https://github.com/dart-lang/angular_analyzer_plugin/pull/273 This is required for cider and for vim integration, ...
3 years, 8 months ago (2017-04-11 21:58:04 UTC) #3
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-11 22:11:32 UTC) #4
mfairhurst
3 years, 8 months ago (2017-04-13 17:37:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d55dc297279810babb84747c19937b3fe23acb8c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698