Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Unified Diff: media/capture/video/linux/video_capture_device_linux.h

Issue 2815643002: Make V4L2CaptureDelegate non-ref-counted (Closed)
Patch Set: mcasas@ comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/linux/video_capture_device_linux.h
diff --git a/media/capture/video/linux/video_capture_device_linux.h b/media/capture/video/linux/video_capture_device_linux.h
index f8368009588c6dd7401912e524a9ef0d80767606..abc7b2db0a419c3ce8b9e311adb9128f7ea6283b 100644
--- a/media/capture/video/linux/video_capture_device_linux.h
+++ b/media/capture/video/linux/video_capture_device_linux.h
@@ -53,9 +53,10 @@ class VideoCaptureDeviceLinux : public VideoCaptureDevice {
static int TranslatePowerLineFrequencyToV4L2(PowerLineFrequency frequency);
// Internal delegate doing the actual capture setting, buffer allocation and
- // circulation with the V4L2 API. Created and deleted in the thread where
- // VideoCaptureDeviceLinux lives but otherwise operating on |v4l2_thread_|.
- scoped_refptr<V4L2CaptureDelegate> capture_impl_;
+ // circulation with the V4L2 API. Created in the thread where
+ // VideoCaptureDeviceLinux lives but otherwise operating and deleted on
+ // |v4l2_thread_|.
+ std::unique_ptr<V4L2CaptureDelegate> capture_impl_;
// Photo-related requests waiting for |v4l2_thread_| to be active.
std::list<base::Closure> photo_requests_queue_;
« no previous file with comments | « media/capture/video/linux/v4l2_capture_delegate_unittest.cc ('k') | media/capture/video/linux/video_capture_device_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698