Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java

Issue 281563002: [Android WebView] Filter out error page URL from onPageFinished to un-flake tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed AwContentsTest#testEscapingOfErrorPage Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java b/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
index b497d90d08f867109cadf3d77df0dbdf4ad25d76..4b3859e0db52ef0b8a75fa4f1368ca8ca91be501 100644
--- a/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
+++ b/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java
@@ -120,9 +120,11 @@ public abstract class WebContentsObserverAndroid {
* @param frameId A positive, non-zero integer identifying the navigating frame.
* @param validatedUrl The validated URL that is being navigated to.
* @param isMainFrame Whether the load is happening for the main frame.
+ * @param isErrorPage Whether the url is the URL of the error page
*/
@CalledByNative
- public void didFinishLoad(long frameId, String validatedUrl, boolean isMainFrame) {
+ public void didFinishLoad(long frameId, String validatedUrl, boolean isMainFrame,
+ boolean isErrorPage) {
}
/**

Powered by Google App Engine
This is Rietveld 408576698