android_webview/java/src/org/chromium/android_webview/AwContentsClient.java - Issue 281563002: [Android WebView] Filter out error page URL from onPageFinished to un-flake tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 281563002: [Android WebView] Filter out error page URL from onPageFinished to un-flake tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed AwContentsTest#testEscapingOfErrorPage Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java » ('j') | content/browser/android/web_contents_observer_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

index 61486bb1ef72ef0ca2d18cce138e56228f50d66d..dba979ca32f36573319ff7abd929f8444cbdc4cb 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

@@ -60,8 +60,9 @@ public abstract class AwContentsClient {

}

@Override

- public void didFinishLoad(long frameId, String validatedUrl, boolean isMainFrame) {

- if (isMainFrame) {

+ public void didFinishLoad(long frameId, String validatedUrl, boolean isMainFrame,

+ boolean isErrorPage) {

+ if (isMainFrame && !isErrorPage) {

bulach 2014/06/17 00:42:12 see below, I suppose we can filter at this level j

mnaganov (inactive) 2014/06/17 09:52:15 Done.

AwContentsClient.this.onPageFinished(validatedUrl);

}