content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java - Issue 281563002: [Android WebView] Filter out error page URL from onPageFinished to un-flake tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java

Issue 281563002: [Android WebView] Filter out error page URL from onPageFinished to un-flake tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Filter out the error page URL on the side of AwContentsClient Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java ('K') | « content/browser/android/web_contents_observer_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java b/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java

index 66e84ad20ceecc8759c93133619a77f29266bed7..e39d9f4f0fcedf3cdd9083dddd86208a2d3f4918 100644

--- a/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java

+++ b/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java

@@ -120,9 +120,11 @@ public abstract class WebContentsObserverAndroid {

* @param frameId A positive, non-zero integer identifying the navigating frame.

* @param validatedUrl The validated URL that is being navigated to.

* @param isMainFrame Whether the load is happening for the main frame.

+ * @param isErrorPage Whether the url is the URL of the error page

@CalledByNative

- public void didFinishLoad(long frameId, String validatedUrl, boolean isMainFrame) {

+ public void didFinishLoad(long frameId, String validatedUrl, boolean isMainFrame,

+ boolean isErrorPage) {

}

/**