Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2281)

Unified Diff: chrome/browser/resources/settings/controls/settings_radio_group.js

Issue 2815593002: MD Settings: circumvent problems with shadow DOM and aria radio* roles (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/controls/settings_radio_group.js
diff --git a/chrome/browser/resources/settings/controls/settings_radio_group.js b/chrome/browser/resources/settings/controls/settings_radio_group.js
index f0bedec092bfa7c54fb40091c3a26c664cba75d6..5f030360d0c30b9a1eb3aa0ae4be6f543a3cd3b9 100644
--- a/chrome/browser/resources/settings/controls/settings_radio_group.js
+++ b/chrome/browser/resources/settings/controls/settings_radio_group.js
@@ -28,6 +28,14 @@ Polymer({
},
},
+ hostAttributes: {
+ // NOTE(dbeam): this should not be necessary, but radiogroup and radio must
+ // be in the same shadow tree, which is not guaranteed so we duplicate roles
+ // of this :host and the *-radio-buttons selected by this template's
+ // <content> tag.
+ role: 'radiogroup',
hcarmona 2017/04/11 17:47:25 Is this needed? The radio buttons are already chil
+ },
+
observers: [
'prefChanged_(pref.*)',
],

Powered by Google App Engine
This is Rietveld 408576698