Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: devil/devil/android/device_utils_test.py

Issue 2815573003: Fix force stop using wrong "ps" cmd. (Closed)
Patch Set: Fix force stop using wrong "ps" cmd. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« devil/devil/android/device_utils.py ('K') | « devil/devil/android/device_utils.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: devil/devil/android/device_utils_test.py
diff --git a/devil/devil/android/device_utils_test.py b/devil/devil/android/device_utils_test.py
index 2490209631075502df03c9f81c035b8da05ef2b6..80157a964217d2e6e4f5827dcf253f7a1a8438a4 100755
--- a/devil/devil/android/device_utils_test.py
+++ b/devil/devil/android/device_utils_test.py
@@ -1539,11 +1539,27 @@ class DeviceUtilsGoHomeTest(DeviceUtilsTest):
class DeviceUtilsForceStopTest(DeviceUtilsTest):
def testForceStop(self):
- with self.assertCall(
- self.call.adb.Shell('p=test.package;if [[ "$(ps)" = *$p* ]]; then '
- 'am force-stop $p; fi'),
- ''):
- self.device.ForceStop('test.package')
+ with self.patch_call(self.call.device.build_version_sdk,
+ return_value=(version_codes.NOUGAT_MR1)):
+ with self.patch_call(self.call.device.build_id,
+ return_value='NNN99N'):
+ with self.assertCall(
+ self.call.adb.Shell('p=test.package;if [[ "$(ps)" = *$p* ]]; then '
+ 'am force-stop $p; fi'),
+ ''):
+ self.device.ForceStop('test.package')
+
+ def testForceStop_sdkGreaterThanNougatMR1(self):
+ with self.patch_call(self.call.device.build_version_sdk,
+ return_value=(version_codes.NOUGAT_MR1 + 1)):
+ with self.patch_call(self.call.device.build_id,
+ return_value='ZZZ99Z'):
+ with self.assertCall(
+ self.call.adb.Shell(
+ 'p=test.package;if [[ "$(ps -e)" = *$p* ]]; then '
+ 'am force-stop $p; fi'),
+ ''):
+ self.device.ForceStop('test.package')
class DeviceUtilsClearApplicationStateTest(DeviceUtilsTest):
« devil/devil/android/device_utils.py ('K') | « devil/devil/android/device_utils.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698