base/threading/worker_pool_win.cc - Issue 2815573002: CHECK tasks posted by TaskRunner::PostTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/worker_pool_win.cc

Issue 2815573002: CHECK tasks posted by TaskRunner::PostTask (Closed)

Patch Set: +comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/threading/worker_pool_win.cc

diff --git a/base/threading/worker_pool_win.cc b/base/threading/worker_pool_win.cc

index 9b1192c9e805949c54b029b393c9613386e80fd1..d0ba4a8d4ec1e6fccf0f13af149ca7bc36faa92f 100644

--- a/base/threading/worker_pool_win.cc

+++ b/base/threading/worker_pool_win.cc

@@ -45,7 +45,9 @@ DWORD CALLBACK WorkItemCallback(void* param) {

// Takes ownership of |pending_task|

bool PostTaskInternal(PendingTask* pending_task, bool task_is_slow) {

- DCHECK(pending_task->task);

+ // Use CHECK instead of DCHECK to crash earlier. See http://crbug.com/711167

+ // for details.

+ CHECK(pending_task->task);

ULONG flags = 0;

if (task_is_slow)

« no previous file with comments | « base/threading/worker_pool_posix.cc ('k') | chrome/browser/after_startup_task_utils.cc » ('j') | no next file with comments »