Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/message_loop/incoming_task_queue.cc

Issue 2815573002: CHECK tasks posted by TaskRunner::PostTask (Closed)
Patch Set: +comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/deferred_sequenced_task_runner.cc ('k') | base/task_scheduler/delayed_task_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/incoming_task_queue.cc
diff --git a/base/message_loop/incoming_task_queue.cc b/base/message_loop/incoming_task_queue.cc
index 316b5ec645d65e0df1b2c5a7b3dd03f76ac341fc..67796ffa377f886e10bf7ff135bf539002101872 100644
--- a/base/message_loop/incoming_task_queue.cc
+++ b/base/message_loop/incoming_task_queue.cc
@@ -63,7 +63,9 @@ bool IncomingTaskQueue::AddToIncomingQueue(
OnceClosure task,
TimeDelta delay,
bool nestable) {
- DCHECK(task);
+ // Use CHECK instead of DCHECK to crash earlier. See http://crbug.com/711167
+ // for details.
+ CHECK(task);
DLOG_IF(WARNING,
delay.InSeconds() > kTaskDelayWarningThresholdInSeconds)
<< "Requesting super-long task delay period of " << delay.InSeconds()
« no previous file with comments | « base/deferred_sequenced_task_runner.cc ('k') | base/task_scheduler/delayed_task_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698