Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc

Issue 2815573002: CHECK tasks posted by TaskRunner::PostTask (Closed)
Patch Set: +comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/categorized_worker_pool.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/scheduler/base/task_queue_impl.h" 5 #include "platform/scheduler/base/task_queue_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/format_macros.h" 9 #include "base/format_macros.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 TaskType::NON_NESTABLE); 216 TaskType::NON_NESTABLE);
217 217
218 return PostDelayedTaskImpl(from_here, std::move(task), delay, 218 return PostDelayedTaskImpl(from_here, std::move(task), delay,
219 TaskType::NON_NESTABLE); 219 TaskType::NON_NESTABLE);
220 } 220 }
221 221
222 bool TaskQueueImpl::PostImmediateTaskImpl( 222 bool TaskQueueImpl::PostImmediateTaskImpl(
223 const tracked_objects::Location& from_here, 223 const tracked_objects::Location& from_here,
224 base::OnceClosure task, 224 base::OnceClosure task,
225 TaskType task_type) { 225 TaskType task_type) {
226 DCHECK(task); 226 // Use CHECK instead of DCHECK to crash earlier. See http://crbug.com/711167
227 // for details.
228 CHECK(task);
227 base::AutoLock lock(any_thread_lock_); 229 base::AutoLock lock(any_thread_lock_);
228 if (!any_thread().task_queue_manager) 230 if (!any_thread().task_queue_manager)
229 return false; 231 return false;
230 232
231 EnqueueOrder sequence_number = 233 EnqueueOrder sequence_number =
232 any_thread().task_queue_manager->GetNextSequenceNumber(); 234 any_thread().task_queue_manager->GetNextSequenceNumber();
233 235
234 PushOntoImmediateIncomingQueueLocked(from_here, std::move(task), 236 PushOntoImmediateIncomingQueueLocked(from_here, std::move(task),
235 base::TimeTicks(), sequence_number, 237 base::TimeTicks(), sequence_number,
236 task_type != TaskType::NON_NESTABLE); 238 task_type != TaskType::NON_NESTABLE);
237 return true; 239 return true;
238 } 240 }
239 241
240 bool TaskQueueImpl::PostDelayedTaskImpl( 242 bool TaskQueueImpl::PostDelayedTaskImpl(
241 const tracked_objects::Location& from_here, 243 const tracked_objects::Location& from_here,
242 base::OnceClosure task, 244 base::OnceClosure task,
243 base::TimeDelta delay, 245 base::TimeDelta delay,
244 TaskType task_type) { 246 TaskType task_type) {
245 DCHECK(task); 247 // Use CHECK instead of DCHECK to crash earlier. See http://crbug.com/711167
248 // for details.
249 CHECK(task);
246 DCHECK_GT(delay, base::TimeDelta()); 250 DCHECK_GT(delay, base::TimeDelta());
247 if (base::PlatformThread::CurrentId() == thread_id_) { 251 if (base::PlatformThread::CurrentId() == thread_id_) {
248 // Lock-free fast path for delayed tasks posted from the main thread. 252 // Lock-free fast path for delayed tasks posted from the main thread.
249 if (!main_thread_only().task_queue_manager) 253 if (!main_thread_only().task_queue_manager)
250 return false; 254 return false;
251 255
252 EnqueueOrder sequence_number = 256 EnqueueOrder sequence_number =
253 main_thread_only().task_queue_manager->GetNextSequenceNumber(); 257 main_thread_only().task_queue_manager->GetNextSequenceNumber();
254 258
255 base::TimeTicks time_domain_now = main_thread_only().time_domain->Now(); 259 base::TimeTicks time_domain_now = main_thread_only().time_domain->Now();
(...skipping 643 matching lines...) Expand 10 before | Expand all | Expand 10 after
899 } 903 }
900 904
901 void TaskQueueImpl::NotifyWakeUpChangedOnMainThread(base::TimeTicks wake_up) { 905 void TaskQueueImpl::NotifyWakeUpChangedOnMainThread(base::TimeTicks wake_up) {
902 if (main_thread_only().observer) 906 if (main_thread_only().observer)
903 main_thread_only().observer->OnQueueNextWakeUpChanged(this, wake_up); 907 main_thread_only().observer->OnQueueNextWakeUpChanged(this, wake_up);
904 } 908 }
905 909
906 } // namespace internal 910 } // namespace internal
907 } // namespace scheduler 911 } // namespace scheduler
908 } // namespace blink 912 } // namespace blink
OLDNEW
« no previous file with comments | « content/renderer/categorized_worker_pool.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698