Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: base/task_scheduler/sequence.cc

Issue 2815573002: CHECK tasks posted by TaskRunner::PostTask (Closed)
Patch Set: +comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/sequence.h" 5 #include "base/task_scheduler/sequence.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
11 11
12 namespace base { 12 namespace base {
13 namespace internal { 13 namespace internal {
14 14
15 Sequence::Sequence() = default; 15 Sequence::Sequence() = default;
16 16
17 bool Sequence::PushTask(std::unique_ptr<Task> task) { 17 bool Sequence::PushTask(std::unique_ptr<Task> task) {
18 DCHECK(task); 18 DCHECK(task);
19 DCHECK(task->task); 19
20 // Use CHECK instead of DCHECK to crash earlier. See http://crbug.com/711167
21 // for details.
22 CHECK(task->task);
20 DCHECK(task->sequenced_time.is_null()); 23 DCHECK(task->sequenced_time.is_null());
21 task->sequenced_time = base::TimeTicks::Now(); 24 task->sequenced_time = base::TimeTicks::Now();
22 25
23 AutoSchedulerLock auto_lock(lock_); 26 AutoSchedulerLock auto_lock(lock_);
24 ++num_tasks_per_priority_[static_cast<int>(task->traits.priority())]; 27 ++num_tasks_per_priority_[static_cast<int>(task->traits.priority())];
25 queue_.push(std::move(task)); 28 queue_.push(std::move(task));
26 29
27 // Return true if the sequence was empty before the push. 30 // Return true if the sequence was empty before the push.
28 return queue_.size() == 1; 31 return queue_.size() == 1;
29 } 32 }
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 next_task_sequenced_time = queue_.front()->sequenced_time; 81 next_task_sequenced_time = queue_.front()->sequenced_time;
79 } 82 }
80 83
81 return SequenceSortKey(priority, next_task_sequenced_time); 84 return SequenceSortKey(priority, next_task_sequenced_time);
82 } 85 }
83 86
84 Sequence::~Sequence() = default; 87 Sequence::~Sequence() = default;
85 88
86 } // namespace internal 89 } // namespace internal
87 } // namespace base 90 } // namespace base
OLDNEW
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_impl.cc ('k') | base/threading/sequenced_worker_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698