Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Side by Side Diff: base/task_scheduler/delayed_task_manager.cc

Issue 2815573002: CHECK tasks posted by TaskRunner::PostTask (Closed)
Patch Set: +comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/delayed_task_manager.h" 5 #include "base/task_scheduler/delayed_task_manager.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/task_runner.h" 11 #include "base/task_runner.h"
12 #include "base/task_scheduler/task.h" 12 #include "base/task_scheduler/task.h"
13 13
14 namespace base { 14 namespace base {
15 namespace internal { 15 namespace internal {
16 16
17 DelayedTaskManager::DelayedTaskManager( 17 DelayedTaskManager::DelayedTaskManager(
18 scoped_refptr<TaskRunner> service_thread_task_runner) 18 scoped_refptr<TaskRunner> service_thread_task_runner)
19 : service_thread_task_runner_(std::move(service_thread_task_runner)) { 19 : service_thread_task_runner_(std::move(service_thread_task_runner)) {
20 DCHECK(service_thread_task_runner_); 20 DCHECK(service_thread_task_runner_);
21 } 21 }
22 22
23 DelayedTaskManager::~DelayedTaskManager() = default; 23 DelayedTaskManager::~DelayedTaskManager() = default;
24 24
25 void DelayedTaskManager::AddDelayedTask( 25 void DelayedTaskManager::AddDelayedTask(
26 std::unique_ptr<Task> task, 26 std::unique_ptr<Task> task,
27 const PostTaskNowCallback& post_task_now_callback) { 27 const PostTaskNowCallback& post_task_now_callback) {
28 DCHECK(task); 28 DCHECK(task);
29 DCHECK(task->task); 29
30 // Use CHECK instead of DCHECK to crash earlier. See http://crbug.com/711167
31 // for details.
32 CHECK(task->task);
30 33
31 const TimeDelta delay = task->delay; 34 const TimeDelta delay = task->delay;
32 DCHECK(!delay.is_zero()); 35 DCHECK(!delay.is_zero());
33 36
34 // TODO(fdoray): Use |task->delayed_run_time| on the service thread 37 // TODO(fdoray): Use |task->delayed_run_time| on the service thread
35 // MessageLoop rather than recomputing it from |delay|. 38 // MessageLoop rather than recomputing it from |delay|.
36 service_thread_task_runner_->PostDelayedTask( 39 service_thread_task_runner_->PostDelayedTask(
37 FROM_HERE, BindOnce(post_task_now_callback, Passed(std::move(task))), 40 FROM_HERE, BindOnce(post_task_now_callback, Passed(std::move(task))),
38 delay); 41 delay);
39 } 42 }
40 43
41 } // namespace internal 44 } // namespace internal
42 } // namespace base 45 } // namespace base
OLDNEW
« no previous file with comments | « base/message_loop/incoming_task_queue.cc ('k') | base/task_scheduler/scheduler_worker_pool_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698