Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: base/deferred_sequenced_task_runner.cc

Issue 2815573002: CHECK tasks posted by TaskRunner::PostTask (Closed)
Patch Set: +comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/message_loop/incoming_task_queue.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/deferred_sequenced_task_runner.h" 5 #include "base/deferred_sequenced_task_runner.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 QueueDeferredTask(from_here, std::move(task), delay, 65 QueueDeferredTask(from_here, std::move(task), delay,
66 true /* is_non_nestable */); 66 true /* is_non_nestable */);
67 return true; 67 return true;
68 } 68 }
69 69
70 void DeferredSequencedTaskRunner::QueueDeferredTask( 70 void DeferredSequencedTaskRunner::QueueDeferredTask(
71 const tracked_objects::Location& from_here, 71 const tracked_objects::Location& from_here,
72 OnceClosure task, 72 OnceClosure task,
73 TimeDelta delay, 73 TimeDelta delay,
74 bool is_non_nestable) { 74 bool is_non_nestable) {
75 DCHECK(task); 75 // Use CHECK instead of DCHECK to crash earlier. See http://crbug.com/711167
76 // for details.
77 CHECK(task);
76 78
77 DeferredTask deferred_task; 79 DeferredTask deferred_task;
78 deferred_task.posted_from = from_here; 80 deferred_task.posted_from = from_here;
79 deferred_task.task = std::move(task); 81 deferred_task.task = std::move(task);
80 deferred_task.delay = delay; 82 deferred_task.delay = delay;
81 deferred_task.is_non_nestable = is_non_nestable; 83 deferred_task.is_non_nestable = is_non_nestable;
82 deferred_tasks_queue_.push_back(std::move(deferred_task)); 84 deferred_tasks_queue_.push_back(std::move(deferred_task));
83 } 85 }
84 86
85 void DeferredSequencedTaskRunner::Start() { 87 void DeferredSequencedTaskRunner::Start() {
86 AutoLock lock(lock_); 88 AutoLock lock(lock_);
87 DCHECK(!started_); 89 DCHECK(!started_);
88 started_ = true; 90 started_ = true;
89 for (std::vector<DeferredTask>::iterator i = deferred_tasks_queue_.begin(); 91 for (std::vector<DeferredTask>::iterator i = deferred_tasks_queue_.begin();
90 i != deferred_tasks_queue_.end(); 92 i != deferred_tasks_queue_.end();
91 ++i) { 93 ++i) {
92 DeferredTask& task = *i; 94 DeferredTask& task = *i;
93 if (task.is_non_nestable) { 95 if (task.is_non_nestable) {
94 target_task_runner_->PostNonNestableDelayedTask( 96 target_task_runner_->PostNonNestableDelayedTask(
95 task.posted_from, std::move(task.task), task.delay); 97 task.posted_from, std::move(task.task), task.delay);
96 } else { 98 } else {
97 target_task_runner_->PostDelayedTask(task.posted_from, 99 target_task_runner_->PostDelayedTask(task.posted_from,
98 std::move(task.task), task.delay); 100 std::move(task.task), task.delay);
99 } 101 }
100 } 102 }
101 deferred_tasks_queue_.clear(); 103 deferred_tasks_queue_.clear();
102 } 104 }
103 105
104 } // namespace base 106 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | base/message_loop/incoming_task_queue.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698