Add support for core dump archiving on macos

Add support for core dump archiving on macos

R=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/a7e6da3a93f93da03f8fee94b1c0175efe7a641d

[kustermann, 2017-04-11 08:05:43]

kustermann@google.com changed reviewers:
+ vegorov@google.com

[kustermann, 2017-04-11 08:05:44]

First attempt and making it work!

[kustermann, 2017-04-12 08:58:53]

kustermann@google.com changed reviewers:
+ whesse@google.com

[Vyacheslav Egorov (Google), 2017-04-18 11:12:51]

lgtm

https://codereview.chromium.org/2815553003/diff/1/tools/utils.py
File tools/utils.py (right):

https://codereview.chromium.org/2815553003/diff/1/tools/utils.py#newcode961
tools/utils.py:961: os.unlink(core)
maybe wrap this in try: for MacOS case - because on Mac the location is global
so this folder can contain some files which we don't own.

[kustermann, 2017-04-19 08:36:13]

https://codereview.chromium.org/2815553003/diff/1/tools/utils.py
File tools/utils.py (right):

https://codereview.chromium.org/2815553003/diff/1/tools/utils.py#newcode961
tools/utils.py:961: os.unlink(core)
On 2017/04/18 11:12:51, Vyacheslav Egorov (Google) wrote:
> maybe wrap this in try: for MacOS case - because on Mac the location is global
> so this folder can contain some files which we don't own.

Done.

[kustermann, 2017-04-19 08:36:30]

Description was changed from

==========
Add support for core dump archiving on macos
==========

to

==========
Add support for core dump archiving on macos

R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a7e6da3a93f93da03f8fee94b1c0175efe7a641d
==========

[kustermann, 2017-04-19 08:36:31]

Committed patchset #2 (id:20001) manually as
a7e6da3a93f93da03f8fee94b1c0175efe7a641d (presubmit successful).