Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: pkg/compiler/lib/src/inferrer/builder.dart

Issue 2815543003: Work-around for issue 29309 (Closed)
Patch Set: comment out test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/simple_inferrer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/inferrer/builder.dart
diff --git a/pkg/compiler/lib/src/inferrer/builder.dart b/pkg/compiler/lib/src/inferrer/builder.dart
index 519524c81e29f663ea84a0452cde8d48b18ece35..886d974d3e947569bbb96fc75114c2d625d3f03f 100644
--- a/pkg/compiler/lib/src/inferrer/builder.dart
+++ b/pkg/compiler/lib/src/inferrer/builder.dart
@@ -698,7 +698,11 @@ class ElementGraphBuilder extends ast.Visitor<TypeInformation>
visit(node.body);
List<ast.Send> tests = <ast.Send>[];
handleCondition(node.condition, tests);
- updateIsChecks(tests, usePositive: true);
+ // TODO(29309): This condition appears to stengthen both the back-edge and
+ // exit-edge. For now, avoid strengthening on the condition until the
+ // proper fix is found.
+ //
+ // updateIsChecks(tests, usePositive: true);
});
}
« no previous file with comments | « no previous file | tests/compiler/dart2js/simple_inferrer_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698