Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: runtime/vm/object.h

Issue 2815533003: Refactor AOT deduplication steps so they can run before an app-jit snapshot as well. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/object_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 50c933ba1339162a1f493fdff568553a34e0747f..2cfe03a353338712fb7f0a3521bd107fec88089d 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -4390,12 +4390,20 @@ class PcDescriptors : public Object {
intptr_t cur_try_index_;
};
+ intptr_t Length() const;
+ bool Equals(const PcDescriptors& other) const {
+ if (Length() != other.Length()) {
+ return false;
+ }
+ NoSafepointScope no_safepoint;
+ return memcmp(raw_ptr(), other.raw_ptr(), InstanceSize(Length())) == 0;
+ }
+
private:
static const char* KindAsStr(RawPcDescriptors::Kind kind);
static RawPcDescriptors* New(intptr_t length);
- intptr_t Length() const;
void SetLength(intptr_t value) const;
void CopyData(GrowableArray<uint8_t>* data);
@@ -4698,7 +4706,7 @@ class Code : public Object {
}
RawArray* await_token_positions() const;
- void SetAwaitTokenPositions(const Array& await_token_positions) const;
+ void set_await_token_positions(const Array& await_token_positions) const;
// Used during reloading (see object_reload.cc). Calls Reset on all ICDatas
// that are embedded inside the Code object.
@@ -5034,7 +5042,7 @@ class Code : public Object {
friend class FunctionSerializationCluster;
friend class CodeSerializationCluster;
friend class CodePatcher; // for set_instructions
- friend class Precompiler; // for set_instructions
+ friend class ProgramVisitor; // for set_instructions
// So that the RawFunction pointer visitor can determine whether code the
// function points to is optimized.
friend class RawFunction;
@@ -5221,7 +5229,7 @@ class MegamorphicCache : public Object {
private:
friend class Class;
friend class MegamorphicCacheTable;
- friend class Precompiler;
+ friend class ProgramVisitor;
static RawMegamorphicCache* New();
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/object_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698