Refactor AOT deduplication steps so they can run before an app-jit snapshot as well.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_OBJECT_H_
 #define RUNTIME_VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 4372 matching lines @@
     const intptr_t kind_mask_;
     intptr_t byte_index_;
 
     intptr_t cur_pc_offset_;
     intptr_t cur_kind_;
     intptr_t cur_deopt_id_;
     intptr_t cur_token_pos_;
     intptr_t cur_try_index_;
   };
 
+  intptr_t Length() const;
+  bool Equals(const PcDescriptors& other) const {
+    if (Length() != other.Length()) {
+      return false;
+    }
+    NoSafepointScope no_safepoint;
+    return memcmp(raw_ptr(), other.raw_ptr(), InstanceSize(Length())) == 0;
+  }
+
  private:
   static const char* KindAsStr(RawPcDescriptors::Kind kind);
 
   static RawPcDescriptors* New(intptr_t length);
 
-  intptr_t Length() const;
   void SetLength(intptr_t value) const;
   void CopyData(GrowableArray<uint8_t>* data);
 
   FINAL_HEAP_OBJECT_IMPLEMENTATION(PcDescriptors, Object);
   friend class Class;
   friend class Object;
 };
 
 
 class CodeSourceMap : public Object {
@@ skipping 282 matching lines @@
   RawCodeSourceMap* code_source_map() const {
     return raw_ptr()->code_source_map_;
   }
 
   void set_code_source_map(const CodeSourceMap& code_source_map) const {
     ASSERT(code_source_map.IsOld());
     StorePointer(&raw_ptr()->code_source_map_, code_source_map.raw());
   }
 
   RawArray* await_token_positions() const;
-  void SetAwaitTokenPositions(const Array& await_token_positions) const;
+  void set_await_token_positions(const Array& await_token_positions) const;
 
   // Used during reloading (see object_reload.cc). Calls Reset on all ICDatas
   // that are embedded inside the Code object.
   void ResetICDatas(Zone* zone) const;
 
   // Array of DeoptInfo objects.
   RawArray* deopt_info_array() const {
 #if defined(DART_PRECOMPILED_RUNTIME)
     UNREACHABLE();
     return NULL;
@@ skipping 315 matching lines @@
   // the RawInstruction and RawCode objects, sets up the pointer offsets
   // and links the two in a GC safe manner.
   static RawCode* New(intptr_t pointer_offsets_length);
 
   FINAL_HEAP_OBJECT_IMPLEMENTATION(Code, Object);
   friend class Class;
   friend class SnapshotWriter;
   friend class FunctionSerializationCluster;
   friend class CodeSerializationCluster;
   friend class CodePatcher;  // for set_instructions
-  friend class Precompiler;  // for set_instructions
+  friend class ProgramVisitor;  // for set_instructions
   // So that the RawFunction pointer visitor can determine whether code the
   // function points to is optimized.
   friend class RawFunction;
 };
 
 
 class Context : public Object {
  public:
   RawContext* parent() const { return raw_ptr()->parent_; }
   void set_parent(const Context& parent) const {
@@ skipping 166 matching lines @@
 
   void Insert(const Smi& class_id, const Function& target) const;
 
   static intptr_t InstanceSize() {
     return RoundedAllocationSize(sizeof(RawMegamorphicCache));
   }
 
  private:
   friend class Class;
   friend class MegamorphicCacheTable;
-  friend class Precompiler;
+  friend class ProgramVisitor;
 
   static RawMegamorphicCache* New();
 
   void set_target_name(const String& value) const;
   void set_arguments_descriptor(const Array& value) const;
 
   enum {
     kClassIdIndex,
     kTargetFunctionIndex,
     kEntryLength,
@@ skipping 3726 matching lines @@
 
 inline void TypeArguments::SetHash(intptr_t value) const {
   // This is only safe because we create a new Smi, which does not cause
   // heap allocation.
   StoreSmi(&raw_ptr()->hash_, Smi::New(value));
 }
 
 }  // namespace dart
 
 #endif  // RUNTIME_VM_OBJECT_H_