Refactor AOT deduplication steps so they can run before an app-jit snapshot as well.

Refactor AOT deduplication steps so they can run before an app-jit snapshot as well.

Additionally dedup PcDescriptors, deopt entries, deopt lists, and await token position lists.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/5cffc591aaecef20c0f0ff9c2860b5fad23f0fab

[rmacnak, 2017-04-12 00:48:48]

Description was changed from

==========
Refactor AOT deduplication steps so they can run before an app-jit snapshot as
well.
==========

to

==========
Refactor AOT deduplication steps so they can run before an app-jit snapshot as
well.

Additionally dedup PcDescriptors, deopt entries, deopt lists, and await token
position lists.
==========

[rmacnak, 2017-04-12 00:59:52]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[rmacnak, 2017-04-12 00:59:52]

dart2js snapshot
34845280 -> 34081216 (-2.2%)
analyzer snapshot
17144608 -> 16787232 (-2.1%)



This might also increase the speed when running from these snapshots:

t -mrelease -cdart2js -rnone --use-sdk --nobatch language
4:35 -> 3:49 (~ -17%)
t -mrelease -cdart2analyzer -rnone --use-sdk --nobatch language
4:43 -> 3:56 (~ -17%)

But I also saw one instance of dart2js spiking up to 6 minutes after the change,
so this might just be noise from load on my machine.

[siva, 2017-04-12 18:25:31]

lgtm

https://codereview.chromium.org/2815533003/diff/40001/runtime/vm/program_visi...
File runtime/vm/program_visitor.cc (right):

https://codereview.chromium.org/2815533003/diff/40001/runtime/vm/program_visi...
runtime/vm/program_visitor.cc:309: reason_and_flags_);
Not important but just an observation that if DedupDeoptEntry returns a null
object when inserting a new entry then this SetEntry could be avoided by
checking the return value for Null

[rmacnak, 2017-04-12 21:18:12]

https://codereview.chromium.org/2815533003/diff/40001/runtime/vm/program_visi...
File runtime/vm/program_visitor.cc (right):

https://codereview.chromium.org/2815533003/diff/40001/runtime/vm/program_visi...
runtime/vm/program_visitor.cc:309: reason_and_flags_);
On 2017/04/12 18:25:31, siva wrote:
> Not important but just an observation that if DedupDeoptEntry returns a null
> object when inserting a new entry then this SetEntry could be avoided by
> checking the return value for Null

It should never return a null. Added assert.

[rmacnak, 2017-04-12 21:23:54]

Description was changed from

==========
Refactor AOT deduplication steps so they can run before an app-jit snapshot as
well.

Additionally dedup PcDescriptors, deopt entries, deopt lists, and await token
position lists.
==========

to

==========
Refactor AOT deduplication steps so they can run before an app-jit snapshot as
well.

Additionally dedup PcDescriptors, deopt entries, deopt lists, and await token
position lists.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5cffc591aaecef20c0f0ff9c2860b5fad23f0fab
==========

[rmacnak, 2017-04-12 21:23:55]

Committed patchset #4 (id:60001) manually as
5cffc591aaecef20c0f0ff9c2860b5fad23f0fab (presubmit successful).