Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 281553002: For page cyclers, move power metrics start to WillNavigate. (Closed)

Created:
6 years, 7 months ago by qsr
Modified:
6 years, 7 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

For page cyclers, move power metrics start to WillNavigate. Page cycler are considering page loads and not interaction with the page, so the power metric must take the page load into account. R=tonyg@chromium.org BUG=361491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/measurements/page_cycler.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
qsr
6 years, 7 months ago (2014-05-12 11:48:20 UTC) #1
dtu
lgtm
6 years, 7 months ago (2014-05-12 18:35:49 UTC) #2
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 7 months ago (2014-05-13 07:48:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/281553002/1
6 years, 7 months ago (2014-05-13 07:48:37 UTC) #4
tonyg
lgtm
6 years, 7 months ago (2014-05-13 08:28:19 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 09:47:57 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 11:08:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/153396)
6 years, 7 months ago (2014-05-13 11:08:27 UTC) #8
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 7 months ago (2014-05-13 11:08:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/281553002/1
6 years, 7 months ago (2014-05-13 11:09:15 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 11:26:24 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 12:15:17 UTC) #12
Message was sent while issue was closed.
Change committed as 270075

Powered by Google App Engine
This is Rietveld 408576698