Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2815513007: Remove Compiler and JavaScriptBackend from main_call_stub_generator and runtime_type_generator (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove Compiler and JavaScriptBackend from main_call_stub_generator and runtime_type_generator This is a step towards passing data object directly instead of accessing data on JavaScriptBackend. This is needed to support an element switch between resolution and codegen. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/d7f28df9e869875207aa430f9f067a612f4a0468

Patch Set 1 #

Patch Set 2 : Add getter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -74 lines) Patch
M pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart View 1 chunk +14 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 10 chunks +27 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 13 chunks +60 lines, -48 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-12 14:03:22 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-04-12 18:04:55 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-04-18 08:39:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d7f28df9e869875207aa430f9f067a612f4a0468 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698