cros: Stop forcing off display when lid events are received

chromeos/dbus/fake_power_manager_client.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_FAKE_POWER_MANAGER_CLIENT_H_
 #define CHROMEOS_DBUS_FAKE_POWER_MANAGER_CLIENT_H_
 
 #include <deque>
 #include <string>
 
@@ skipping 25 matching lines @@
     return num_set_is_projecting_calls_;
   }
   bool is_projecting() const { return is_projecting_; }
   bool have_video_activity_report() const {
     return !video_activity_reports_.empty();
   }
   int num_set_backlights_forced_off_calls() const {
     return num_set_backlights_forced_off_calls_;
   }
 
   void set_lid_state(LidState state) { lid_state_ = state; }

[Qiang(Joe) Xu, 2017/04/13 04:14:18]

set_lid_state is not used anywhere. Do we want to keep it?

[Daniel Erat, 2017/04/13 04:31:16]

i think it's there so it can be used by future code that calls GetSwitchStates.
feel free to remove it since your new method can also be used to change the
state.

[Qiang(Joe) Xu, 2017/04/13 04:49:40]

Done.

   void set_tablet_mode(TabletMode mode) { tablet_mode_ = mode; }
 
   // PowerManagerClient overrides
   void Init(dbus::Bus* bus) override;
   void AddObserver(Observer* observer) override;
   void RemoveObserver(Observer* observer) override;
   bool HasObserver(const Observer* observer) const override;
   void SetRenderProcessManagerDelegate(
       base::WeakPtr<RenderProcessManagerDelegate> delegate) override;
   void DecreaseScreenBrightness(bool allow_off) override;
@@ skipping 29 matching lines @@
   void SendSuspendDone();
   void SendDarkSuspendImminent();
 
   // Emulates the power manager announcing that the system is changing
   // brightness to |level|.
   void SendBrightnessChanged(int level, bool user_initiated);
 
   // Notifies observers that the power button has been pressed or released.
   void SendPowerButtonEvent(bool down, const base::TimeTicks& timestamp);
 
+  // Notifies observers that LidState is switched to |state|.
+  void SendLidEvent(LidState state, const base::TimeTicks& timestamp);

[Daniel Erat, 2017/04/13 04:31:16]

how about renaming this to SetLidState? that makes it clearer that it's updating
this class's internal state as well.

[Qiang(Joe) Xu, 2017/04/13 04:49:40]

agree. Done.

+
   // Updates |props_| and notifies observers of its changes.
   void UpdatePowerProperties(
       const power_manager::PowerSupplyProperties& power_props);
 
  private:
   // Callback that will be run by asynchronous suspend delays to report
   // readiness.
   void HandleSuspendReadiness();
 
   // Notifies |observers_| that |props_| has been updated.
@@ skipping 38 matching lines @@
   // Note: This should remain the last member so it'll be destroyed and
   // invalidate its weak pointers before any other members are destroyed.
   base::WeakPtrFactory<FakePowerManagerClient> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(FakePowerManagerClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_FAKE_POWER_MANAGER_CLIENT_H_