[Bindings] Use SetNativeDataProperty to install features on instances

third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 77 matching lines @@
 }
 
 void InstallAttributeInternal(
     v8::Isolate* isolate,
     v8::Local<v8::Object> instance,
     v8::Local<v8::Object> prototype,
     const V8DOMConfiguration::AttributeConfiguration& attribute,
     const DOMWrapperWorld& world) {
   if (!WorldConfigurationApplies(attribute, world))
     return;
+
   v8::Local<v8::Name> name = V8AtomicString(isolate, attribute.name);
+  v8::AccessorNameGetterCallback getter = attribute.getter;
+  v8::AccessorNameSetterCallback setter = attribute.setter;
+  v8::Local<v8::Value> data =
+      v8::External::New(isolate, const_cast<WrapperTypeInfo*>(attribute.data));
 
   // This method is only being used for installing interfaces which are
   // enabled through origin trials. Assert here that it is being called with
   // an attribute configuration for a constructor.
   // TODO(iclelland): Relax this constraint and allow arbitrary data-type
   // properties to be added here.
-  DCHECK_EQ(&V8ConstructorAttributeGetter, attribute.getter);
+  DCHECK_EQ(&V8ConstructorAttributeGetter, getter);
 
-  V8PerContextData* per_context_data =
-      V8PerContextData::From(isolate->GetCurrentContext());
-  v8::Local<v8::Function> data =
-      per_context_data->ConstructorForType(attribute.data);
-
+  v8::Local<v8::Context> context = isolate->GetCurrentContext();
   DCHECK(attribute.property_location_configuration);
   if (attribute.property_location_configuration &
-      V8DOMConfiguration::kOnInstance)
+      V8DOMConfiguration::kOnInstance) {
     instance
-        ->DefineOwnProperty(
-            isolate->GetCurrentContext(), name, data,
-            static_cast<v8::PropertyAttribute>(attribute.attribute))
+        ->SetAccessor(context, name, getter, setter, data, v8::DEFAULT,

[jbroman, 2017/04/13 14:54:45]

This is only for origin trials, so maybe you've already accepted it as okay, but
this does change what was previously a data property to now be an accessor
property, which is a visible change to authors.

(We don't currently expose an equivalent of SetNativeDataProperty or
SetLazyDataProperty on v8::Object like we do on v8::Template, but I think we
could.)

[haraken, 2017/04/13 15:40:19]

The name is really confusing but:

- SetAccessor => data property
- SetAccessorProerpty => accessor property

if I'm understanding correctly.

[jbroman, 2017/04/13 17:11:23]

Ah. If that's the case, then ignore me (though it is indeed confusing).

+                      static_cast<v8::PropertyAttribute>(attribute.attribute))
         .ToChecked();
+  }
   if (attribute.property_location_configuration &
-      V8DOMConfiguration::kOnPrototype)
+      V8DOMConfiguration::kOnPrototype) {
     prototype
-        ->DefineOwnProperty(
-            isolate->GetCurrentContext(), name, data,
-            static_cast<v8::PropertyAttribute>(attribute.attribute))
+        ->SetAccessor(context, name, getter, setter, data, v8::DEFAULT,
+                      static_cast<v8::PropertyAttribute>(attribute.attribute))
         .ToChecked();
+  }
   if (attribute.property_location_configuration &
       V8DOMConfiguration::kOnInterface)
     NOTREACHED();
 }
 
 void InstallLazyDataAttributeInternal(
     v8::Isolate* isolate,
     v8::Local<v8::ObjectTemplate> instance_template,
     v8::Local<v8::ObjectTemplate> prototype_template,
     const V8DOMConfiguration::AttributeConfiguration& attribute,
@@ skipping 565 matching lines @@
     v8::Isolate* isolate,
     v8::Local<v8::ObjectTemplate> object_template,
     const char* class_string) {
   object_template->Set(
       v8::Symbol::GetToStringTag(isolate),
       V8AtomicString(isolate, class_string),
       static_cast<v8::PropertyAttribute>(v8::ReadOnly | v8::DontEnum));
 }
 
 }  // namespace blink