Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2926)

Unified Diff: build/config/features.gni

Issue 2815453004: For building v8 using gn on aix_ppc64, linux_s390x and linux_ppc64. (Closed)
Patch Set: rebased, addressed reviews, added host_byteorder.gni. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/features.gni
diff --git a/build/config/features.gni b/build/config/features.gni
index d143dac4b89ce082835f225866a0e9f164ccc019..7bb8b6397cb30b9953c63fa32cbcb440b5f70ab6 100644
--- a/build/config/features.gni
+++ b/build/config/features.gni
@@ -22,10 +22,12 @@ if (is_android) {
declare_args() {
# Enables Native Client support.
- # Temporarily disable nacl on arm64 linux to get rid of compilation errors.
+ # Temporarily disable nacl on arm64 linux, ppc64 and s390x
+ # to get rid of compilation errors.
# TODO(mcgrathr): When mipsel-nacl-clang is available, drop the exclusion.
- enable_nacl = !is_ios && !is_android && !is_chromecast &&
- current_cpu != "mipsel" && !(is_linux && target_cpu == "arm64")
+ enable_nacl =
+ !is_ios && !is_android && !is_chromecast && current_cpu != "mipsel" &&
+ !(is_linux && target_cpu == "arm64") && !is_power_or_z
Michael Achenbach 2017/04/25 14:08:30 Double-checking: Here's a subtle difference now to
rayb 2017/04/25 17:28:48 Form my understanding it's not supported on the ho
# Non-SFI is not yet supported on mipsel
enable_nacl_nonsfi = current_cpu != "mipsel"
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/config/gcc/BUILD.gn » ('j') | build/config/ui.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698