chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java - Issue 2815453002: [Android] Show Browser Actions dialog in Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java

Issue 2815453002: [Android] Show Browser Actions dialog in Chrome (Closed)

Patch Set: Fix tests fail. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java

index ed8b36eb4d3d71a6dd650787974d6f33bada7164..645bc79119ca1be61de42b4807458db46e5d65c3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java

@@ -22,7 +22,7 @@ import java.util.List;

public class PlatformContextMenuUi implements ContextMenuUi {

private ContextMenu mMenu;

- PlatformContextMenuUi(ContextMenu menu) {

+ public PlatformContextMenuUi(ContextMenu menu) {

mMenu = menu;

}

@@ -46,7 +46,7 @@ public class PlatformContextMenuUi implements ContextMenuUi {

List<ContextMenuItem> group = itemGroups.get(groupIndex).second;

for (int itemIndex = 0; itemIndex < group.size(); itemIndex++) {

ContextMenuItem item = group.get(itemIndex);

- MenuItem menuItem = mMenu.add(0, item.menuId, 0, item.getString(activity));

+ MenuItem menuItem = mMenu.add(0, item.getMenuId(), 0, item.getTitle(activity));

menuItem.setOnMenuItemClickListener(menuListener);

}