Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java

Issue 2815453002: [Android] Show Browser Actions dialog in Chrome (Closed)
Patch Set: Update based on Maria's comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
index eed6bef5ca1035d0cad190acbf53a6acf44724ed..24772fc9fa39eca5dcc064a24fc5bb50adcbdf8a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
@@ -26,6 +26,16 @@ import java.util.List;
* list view.
*/
class TabularContextMenuListAdapter extends BaseAdapter {
+ /**
+ * Interface to be implemented handle direct share.
+ */
+ public interface DirectShareDelegate {
Ted C 2017/05/12 23:35:26 no longer needed?
ltian 2017/05/15 21:47:04 Oh, yes, sorry forget removing it.
+ /**
+ * Called when direct share icon is clicked.
+ */
+ void onDirectShare();
+ }
+
private final List<ContextMenuItem> mMenuItems;
private final Activity mActivity;
private final Runnable mOnDirectShare;
@@ -54,7 +64,7 @@ class TabularContextMenuListAdapter extends BaseAdapter {
@Override
public long getItemId(int position) {
- return mMenuItems.get(position).menuId;
+ return mMenuItems.get(position).getMenuId();
}
@Override
@@ -79,12 +89,12 @@ class TabularContextMenuListAdapter extends BaseAdapter {
viewHolder = (ViewHolderItem) convertView.getTag();
}
- viewHolder.mText.setText(menuItem.getString(mActivity));
+ viewHolder.mText.setText(menuItem.getTitle(mActivity));
Drawable icon = menuItem.getDrawableAndDescription(mActivity);
viewHolder.mIcon.setImageDrawable(icon);
viewHolder.mIcon.setVisibility(icon != null ? View.VISIBLE : View.INVISIBLE);
- if (menuItem == ContextMenuItem.SHARE_IMAGE) {
+ if (menuItem == ChromeContextMenuItem.SHARE_IMAGE) {
Intent shareIntent = ShareHelper.getShareImageIntent(null);
final Pair<Drawable, CharSequence> shareInfo =
ShareHelper.getShareableIconAndName(mActivity, shareIntent);

Powered by Google App Engine
This is Rietveld 408576698