Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: runtime/bin/vmservice/loader.dart

Issue 2815433002: Fix logic bug in loader code (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of vmservice_io; 5 part of vmservice_io;
6 6
7 _sanitizeWindowsPath(path) { 7 _sanitizeWindowsPath(path) {
8 // For Windows we need to massage the paths a bit according to 8 // For Windows we need to massage the paths a bit according to
9 // http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx 9 // http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx
10 // 10 //
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 _rootScript = Uri.parse(rootScript); 83 _rootScript = Uri.parse(rootScript);
84 } 84 }
85 // If the --package-root flag was passed. 85 // If the --package-root flag was passed.
86 if (packageRootFlag != null) { 86 if (packageRootFlag != null) {
87 _setPackageRoot(packageRootFlag); 87 _setPackageRoot(packageRootFlag);
88 } 88 }
89 // If the --packages flag was passed. 89 // If the --packages flag was passed.
90 if (packagesConfigFlag != null) { 90 if (packagesConfigFlag != null) {
91 _setPackagesConfig(packagesConfigFlag); 91 _setPackagesConfig(packagesConfigFlag);
92 } 92 }
93 if (_fileRequestQueue != null) { 93 if (_fileRequestQueue == null) {
94 _fileRequestQueue = new List<FileRequest>(); 94 _fileRequestQueue = new List<FileRequest>();
95 } 95 }
96 } 96 }
97 97
98 void cleanup() { 98 void cleanup() {
99 _dead = true; 99 _dead = true;
100 if (_packagesPort != null) { 100 if (_packagesPort != null) {
101 _packagesPort.close(); 101 _packagesPort.close();
102 _packagesPort = null; 102 _packagesPort = null;
103 } 103 }
(...skipping 1046 matching lines...) Expand 10 before | Expand all | Expand 10 after
1150 msg[2] = resolvedUri.toString(); 1150 msg[2] = resolvedUri.toString();
1151 msg[3] = null; 1151 msg[3] = null;
1152 msg[4] = e.toString(); 1152 msg[4] = e.toString();
1153 sp.send(msg); 1153 sp.send(msg);
1154 } 1154 }
1155 break; 1155 break;
1156 default: 1156 default:
1157 _log('Unknown loader request tag=$tag from $isolateId'); 1157 _log('Unknown loader request tag=$tag from $isolateId');
1158 } 1158 }
1159 } 1159 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698