Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2815423003: Skip self-referential frame checks for POST requests (Merge to M58). (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index 380b80a125aa2b843387d6e2020c9d387171e864..4ebe13f190b6f137fe359df74015d9adc0872fcb 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -947,6 +947,12 @@ bool NavigationHandleImpl::IsSelfReferentialURL() {
if (!is_renderer_initiated_)
return false;
+ // Some sites rely on constructing frame hierarchies where frames are loaded
+ // via POSTs with the same URLs, so exempt POST requests. See
+ // https://crbug.com/710008.
+ if (method_ == "POST")
+ return false;
+
// We allow one level of self-reference because some sites depend on that,
// but we don't allow more than one.
bool found_self_reference = false;
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698