Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Issue 2815413002: Relax self-referential frame checks for non-initial navigations. (Closed)

Created:
3 years, 8 months ago by alexmos
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Relax self-referential frame checks for non-initial navigations. The improved self-referential frame blocking in r450728 broke sites that rely on constructing frame hierarchies where frames are loaded via POSTs with the same URLs. To fix this, and potentially other breakage from the tightened check, only enforce self-referential URL checks for the initial load in a frame. There's no way for a frame's first committed URL to be a POST, so this fix handles POST requests automatically. It also more closely matches the old Blink check (that was moved to browser process in r450728), which was only enforced on initial navigation during frame creation and on changes to an iframe's "src" attribute (the latter bit is lost with this more conservative check). BUG=710008 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -24 lines) Patch
M content/browser/frame_host/navigation_handle_impl.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 3 chunks +77 lines, -24 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
alexmos
The CQ bit was checked by alexmos@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-13 21:22:49 UTC) #1
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 21:23:31 UTC) #2

Powered by Google App Engine
This is Rietveld 408576698