Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2815383003: Finish cleaning up analyzer warnings (Closed)

Created:
3 years, 8 months ago by kevmoo
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Finish cleaning up analyzer warnings Also Updated pubspec to use the SDK version of kernel Closes https://github.com/dart-lang/sdk/issues/28454 R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/1120d10daf8db3debad83e1af2f8608408571b75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
A pkg/compiler/.gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js/placeholder_safety.dart View 4 chunks +12 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/pubspec.yaml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kevmoo
3 years, 8 months ago (2017-04-14 01:19:49 UTC) #2
Emily Fortuna
lgtm. sorry about that
3 years, 8 months ago (2017-04-14 17:23:27 UTC) #3
kevmoo
3 years, 8 months ago (2017-04-14 17:28:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1120d10daf8db3debad83e1af2f8608408571b75 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698