DevTools: Add more views to command menu

third_party/WebKit/Source/devtools/front_end/quick_open/CommandMenu.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 QuickOpen.CommandMenu = class {
   constructor() {
     this._commands = [];
     this._loadCommands();
@@ skipping 53 matching lines @@
   static createRevealPanelCommand(extension) {
     var panelId = extension.descriptor()['id'];
     var executeHandler = UI.viewManager.showView.bind(UI.viewManager, panelId);
     var tags = extension.descriptor()['tags'] || '';
     return QuickOpen.CommandMenu.createCommand(
         Common.UIString('Panel'), tags, Common.UIString('Show %s', extension.title()), '', executeHandler);
   }
 
   /**
    * @param {!Runtime.Extension} extension
+   * @param {string} category
    * @return {!QuickOpen.CommandMenu.Command}
    */
-  static createRevealDrawerCommand(extension) {
-    var drawerId = extension.descriptor()['id'];
-    var executeHandler = UI.viewManager.showView.bind(UI.viewManager, drawerId);
+  static createRevealViewCommand(extension, category) {
+    var viewId = extension.descriptor()['id'];
+    var executeHandler = UI.viewManager.showView.bind(UI.viewManager, viewId);
     var tags = extension.descriptor()['tags'] || '';
     return QuickOpen.CommandMenu.createCommand(
-        Common.UIString('Drawer'), tags, Common.UIString('Show %s', extension.title()), '', executeHandler);
+        category, tags, Common.UIString('Show %s', extension.title()), '', executeHandler);
   }
 
   _loadCommands() {
+    var locations = new Map();
+    self.runtime.extensions(UI.ViewLocationResolver).forEach(extension => {
+      var category = extension.descriptor()['category'];
+      var name = extension.descriptor()['name'];
+      if (category && name)
+        locations.set(name, category);
+    });
     var viewExtensions = self.runtime.extensions('view');
     for (var extension of viewExtensions) {
-      if (extension.descriptor()['location'] === 'panel')
+      var location = extension.descriptor()['location'];
+      if (location === 'panel')

[pfeldman, 2017/04/17 23:15:54]

We are missing a resolver for the panels, you should not need to special-case
this one if you created a resolver.

[einbinder, 2017/04/17 23:52:06]

Done.

         this._commands.push(QuickOpen.CommandMenu.createRevealPanelCommand(extension));
-      else if (extension.descriptor()['location'] === 'drawer-view')
-        this._commands.push(QuickOpen.CommandMenu.createRevealDrawerCommand(extension));
+      else if (locations.has(location))
+        this._commands.push(QuickOpen.CommandMenu.createRevealViewCommand(extension, locations.get(location)));
     }
 
     // Populate whitelisted settings.
     var settingExtensions = self.runtime.extensions('setting');
     for (var extension of settingExtensions) {
       var options = extension.descriptor()['options'];
       if (!options || !extension.descriptor()['category'])
         continue;
       for (var pair of options)
         this._commands.push(QuickOpen.CommandMenu.createSettingCommand(extension, pair['title'], pair['value']));
@@ skipping 213 matching lines @@
    * @override
    * @param {!UI.Context} context
    * @param {string} actionId
    * @return {boolean}
    */
   handleAction(context, actionId) {
     QuickOpen.QuickOpen.show('>');
     return true;
   }
 };