content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc - Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)

Patch Set: Actually fix fuzzers. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/media/service/cast_mojo_media_client.cc ('K') | « content/renderer/media/webmediaplayer_ms_unittest.cc ('k') | content/renderer/pepper/video_decoder_shim.cc » ('j') | media/blink/webmediaplayer_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc

diff --git a/content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc b/content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc

index 5b4f350d030dcc581abce4ae7a07b23a5be2cb86..444fc3094c787057c70334408b6f679ee8f95528 100644

--- a/content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc

+++ b/content/renderer/media_capture_from_element/html_audio_element_capturer_source_unittest.cc

@@ -69,7 +69,7 @@ class HTMLAudioElementCapturerSourceTest : public testing::Test {

: fake_callback_(0.1, kAudioTrackSampleRate),

audio_source_(new media::WebAudioSourceProviderImpl(

new media::NullAudioSink(base::ThreadTaskRunnerHandle::Get()),

- new media::MediaLog())) {}

+ &media_log_)) {}

void SetUp() final {

const media::AudioParameters params(

@@ -117,6 +117,7 @@ class HTMLAudioElementCapturerSourceTest : public testing::Test {

blink::WebMediaStreamSource blink_audio_source_;

blink::WebMediaStreamTrack blink_audio_track_;

+ media::MediaLog media_log_;

media::FakeAudioRenderCallback fake_callback_;

scoped_refptr<media::WebAudioSourceProviderImpl> audio_source_;

};