Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: testing/libfuzzer/fuzzers/es_parser_mpeg1audio_fuzzer.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/test/pipeline_integration_test_base.cc ('k') | testing/libfuzzer/fuzzers/mp4_box_reader_fuzzer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/libfuzzer/fuzzers/es_parser_mpeg1audio_fuzzer.cc
diff --git a/testing/libfuzzer/fuzzers/es_parser_mpeg1audio_fuzzer.cc b/testing/libfuzzer/fuzzers/es_parser_mpeg1audio_fuzzer.cc
index 94b8a60c5aa29749f629d3c028c52f0b2aa264fb..6afacd24dc48c04ea876298c88eefc03db3d50e6 100644
--- a/testing/libfuzzer/fuzzers/es_parser_mpeg1audio_fuzzer.cc
+++ b/testing/libfuzzer/fuzzers/es_parser_mpeg1audio_fuzzer.cc
@@ -13,13 +13,10 @@
class NullMediaLog : public media::MediaLog {
public:
NullMediaLog() {}
+ ~NullMediaLog() override {}
- void DoAddEventLogString(const std::string& event) {}
void AddEvent(std::unique_ptr<media::MediaLogEvent> event) override {}
- protected:
- virtual ~NullMediaLog() {}
-
private:
DISALLOW_COPY_AND_ASSIGN(NullMediaLog);
};
@@ -29,13 +26,12 @@ static void EmitBuffer(scoped_refptr<media::StreamParserBuffer> buffer) {}
// Entry point for LibFuzzer.
extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
- scoped_refptr<NullMediaLog> media_log(new NullMediaLog());
- media::mp2t::EsParserMpeg1Audio es_parser(base::Bind(&NewAudioConfig),
- base::Bind(&EmitBuffer), media_log);
- if (!es_parser.Parse(data, size, media::kNoTimestamp,
- media::kNoDecodeTimestamp())) {
- return 0;
+ NullMediaLog media_log;
+ media::mp2t::EsParserMpeg1Audio es_parser(
+ base::Bind(&NewAudioConfig), base::Bind(&EmitBuffer), &media_log);
+ if (es_parser.Parse(data, size, media::kNoTimestamp,
+ media::kNoDecodeTimestamp())) {
+ es_parser.Flush();
}
- es_parser.Flush();
return 0;
}
« no previous file with comments | « media/test/pipeline_integration_test_base.cc ('k') | testing/libfuzzer/fuzzers/mp4_box_reader_fuzzer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698