Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: media/mojo/services/media_service.cc

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/media_service.h ('k') | media/mojo/services/mojo_media_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/media_service.cc
diff --git a/media/mojo/services/media_service.cc b/media/mojo/services/media_service.cc
index e1b514597ec030a3cd56f94e1159f6ac0a56df81..a3ff2a5340fa2febb3547305258be80d04c50c59 100644
--- a/media/mojo/services/media_service.cc
+++ b/media/mojo/services/media_service.cc
@@ -17,8 +17,7 @@ namespace media {
// TODO(xhwang): Hook up MediaLog when possible.
MediaService::MediaService(std::unique_ptr<MojoMediaClient> mojo_media_client)
- : mojo_media_client_(std::move(mojo_media_client)),
- media_log_(new MediaLog()) {
+ : mojo_media_client_(std::move(mojo_media_client)) {
DCHECK(mojo_media_client_);
registry_.AddInterface<mojom::MediaService>(this);
}
@@ -59,7 +58,7 @@ void MediaService::CreateInterfaceFactory(
mojo::MakeStrongBinding(
base::MakeUnique<InterfaceFactoryImpl>(
- std::move(host_interfaces), media_log_, ref_factory_->CreateRef(),
+ std::move(host_interfaces), &media_log_, ref_factory_->CreateRef(),
mojo_media_client_.get()),
std::move(request));
}
« no previous file with comments | « media/mojo/services/media_service.h ('k') | media/mojo/services/mojo_media_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698