Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Side by Side Diff: media/base/pipeline_impl.h

Issue 2815303006: Convert MediaLog from being ref counted to owned by WebMediaPlayer. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/base/mock_media_log.h ('k') | media/base/pipeline_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_BASE_PIPELINE_IMPL_H_ 5 #ifndef MEDIA_BASE_PIPELINE_IMPL_H_
6 #define MEDIA_BASE_PIPELINE_IMPL_H_ 6 #define MEDIA_BASE_PIPELINE_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 void OnVideoNaturalSizeChange(const gfx::Size& size); 136 void OnVideoNaturalSizeChange(const gfx::Size& size);
137 void OnVideoOpacityChange(bool opaque); 137 void OnVideoOpacityChange(bool opaque);
138 void OnVideoAverageKeyframeDistanceUpdate(); 138 void OnVideoAverageKeyframeDistanceUpdate();
139 139
140 // Task completion callbacks from RendererWrapper. 140 // Task completion callbacks from RendererWrapper.
141 void OnSeekDone(); 141 void OnSeekDone();
142 void OnSuspendDone(); 142 void OnSuspendDone();
143 143
144 // Parameters passed in the constructor. 144 // Parameters passed in the constructor.
145 const scoped_refptr<base::SingleThreadTaskRunner> media_task_runner_; 145 const scoped_refptr<base::SingleThreadTaskRunner> media_task_runner_;
146 const scoped_refptr<MediaLog> media_log_; 146 MediaLog* const media_log_;
147 147
148 // Pipeline client. Valid only while the pipeline is running. 148 // Pipeline client. Valid only while the pipeline is running.
149 Client* client_; 149 Client* client_;
150 150
151 // RendererWrapper instance that runs on the media thread. 151 // RendererWrapper instance that runs on the media thread.
152 std::unique_ptr<RendererWrapper> renderer_wrapper_; 152 std::unique_ptr<RendererWrapper> renderer_wrapper_;
153 153
154 // Temporary callback used for Start(), Seek(), and Resume(). 154 // Temporary callback used for Start(), Seek(), and Resume().
155 PipelineStatusCB seek_cb_; 155 PipelineStatusCB seek_cb_;
156 156
(...skipping 24 matching lines...) Expand all
181 181
182 base::ThreadChecker thread_checker_; 182 base::ThreadChecker thread_checker_;
183 base::WeakPtrFactory<PipelineImpl> weak_factory_; 183 base::WeakPtrFactory<PipelineImpl> weak_factory_;
184 184
185 DISALLOW_COPY_AND_ASSIGN(PipelineImpl); 185 DISALLOW_COPY_AND_ASSIGN(PipelineImpl);
186 }; 186 };
187 187
188 } // namespace media 188 } // namespace media
189 189
190 #endif // MEDIA_BASE_PIPELINE_IMPL_H_ 190 #endif // MEDIA_BASE_PIPELINE_IMPL_H_
OLDNEW
« no previous file with comments | « media/base/mock_media_log.h ('k') | media/base/pipeline_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698