Update the Windows iOS promotion to have the same width as the bubble that appears before it.

chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util.h"
 
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/metrics/field_trial_params.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/vector_icons/vector_icons.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
+#include "chrome/grit/locale_settings.h"
 #include "components/browser_sync/profile_sync_service.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_registry_simple.h"
 #include "components/prefs/pref_service.h"
 #include "third_party/libphonenumber/phonenumber_api.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/color_utils.h"
 #include "ui/gfx/paint_vector_icon.h"
 #include "ui/native_theme/native_theme.h"
+#include "ui/views/widget/widget.h"

[sky, 2017/04/17 17:21:55]

Code in c/b/ui should not depend upon views. Code in c/b/ui/views can.

[mrefaat, 2017/04/17 19:10:49]

Done.

 
 using i18n::phonenumbers::PhoneNumber;
 using i18n::phonenumbers::PhoneNumberUtil;
 
 namespace desktop_ios_promotion {
 
 // Default Impression cap. for each entry point.
 const int kEntryPointImpressionCap[] = {0, 2, 2, 5, 10};
 
 const char* kEntrypointHistogramPrefix[] = {
@@ skipping 101 matching lines @@
   int body_text_i10_id = kBubbleBodyTextWithPhoneNumberId[text_id_from_finch];
   if (phone_number.empty()) {
     body_text_i10_id = kBubbleBodyTextNoPhoneNumberId[text_id_from_finch];
     return l10n_util::GetStringUTF16(body_text_i10_id)
         .append(base::string16(13, ' '));
   }
   return l10n_util::GetStringFUTF16(body_text_i10_id,
                                     base::UTF8ToUTF16(phone_number));
 }
 
+int GetPromoBubbleTextLabelWidth(PromotionEntryPoint entry_point) {
+  if (entry_point == PromotionEntryPoint::SAVE_PASSWORD_BUBBLE) {
+    return views::Widget::GetLocalizedContentsWidth(
+        IDS_DESKTOP_IOS_PROMOTION_SAVE_PASSWORDS_BUBBLE_TEXT_WIDTH_CHARS);
+  }
+  return views::Widget::GetLocalizedContentsWidth(
+      IDS_DESKTOP_IOS_PROMOTION_TEXT_WIDTH_CHARS);
+}
+
 base::string16 GetPromoTitle(
     desktop_ios_promotion::PromotionEntryPoint entry_point) {
   int text_id_from_finch = base::GetFieldTrialParamByFeatureAsInt(
       features::kDesktopIOSPromotion, "title_text_id", 0);
   return l10n_util::GetStringUTF16(
       kBubbleTitleTextId[static_cast<int>(entry_point)][text_id_from_finch]);
 }
 
 std::string GetSMSID() {
   const std::string default_sms_message_id = "19001507";
@@ skipping 65 matching lines @@
               entry_point)]),
       dismissal_reason_min,
       static_cast<int>(PromotionDismissalReason::DISMISSAL_REASON_MAX_VALUE),
       static_cast<int>(PromotionDismissalReason::DISMISSAL_REASON_MAX_VALUE) +
           1,
       base::HistogramBase::kUmaTargetedHistogramFlag)
       ->Add(static_cast<int>(reason));
 }
 
 }  // namespace desktop_ios_promotion