Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Side by Side Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 2815293003: Disable Flaky OpenImageFiles Test (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/chromeos/drive/file_system_util.h" 9 #include "chrome/browser/chromeos/drive/file_system_util.h"
10 #include "chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h" 10 #include "chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatModeSingleFileDrive"), 114 TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatModeSingleFileDrive"),
115 TestParameter(NOT_IN_GUEST_MODE, "audioRepeatOneModeSingleFileDrive"), 115 TestParameter(NOT_IN_GUEST_MODE, "audioRepeatOneModeSingleFileDrive"),
116 // TODO(crbug.com/701922) Revive this flaky test. 116 // TODO(crbug.com/701922) Revive this flaky test.
117 // TestParameter(NOT_IN_GUEST_MODE, 117 // TestParameter(NOT_IN_GUEST_MODE,
118 // "audioRepeatAllModeMultipleFileDrive"), 118 // "audioRepeatAllModeMultipleFileDrive"),
119 TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatModeMultipleFileDrive"), 119 TestParameter(NOT_IN_GUEST_MODE, "audioNoRepeatModeMultipleFileDrive"),
120 TestParameter(NOT_IN_GUEST_MODE, 120 TestParameter(NOT_IN_GUEST_MODE,
121 "audioRepeatOneModeMultipleFileDrive"))); 121 "audioRepeatOneModeMultipleFileDrive")));
122 122
123 // Fails on official build. http://crbug.com/429294 123 // Fails on official build. http://crbug.com/429294
124 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD) 124 // Flaky: http://crbug.com/711290
125 #define MAYBE_OpenImageFiles DISABLED_OpenImageFiles
126 #else
127 #define MAYBE_OpenImageFiles OpenImageFiles
128 #endif
129 WRAPPED_INSTANTIATE_TEST_CASE_P( 125 WRAPPED_INSTANTIATE_TEST_CASE_P(
130 MAYBE_OpenImageFiles, 126 DISABLED_OpenImageFiles,
131 FileManagerBrowserTest, 127 FileManagerBrowserTest,
132 ::testing::Values(TestParameter(IN_GUEST_MODE, "imageOpenDownloads"), 128 ::testing::Values(TestParameter(IN_GUEST_MODE, "imageOpenDownloads"),
133 TestParameter(NOT_IN_GUEST_MODE, "imageOpenDownloads"), 129 TestParameter(NOT_IN_GUEST_MODE, "imageOpenDownloads"),
134 TestParameter(NOT_IN_GUEST_MODE, "imageOpenDrive"))); 130 TestParameter(NOT_IN_GUEST_MODE, "imageOpenDrive")));
135 131
136 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD) 132 #if defined(DISABLE_SLOW_FILESAPP_TESTS) || defined(OFFICIAL_BUILD)
137 #define MAYBE_CreateNewFolder DISABLED_CreateNewFolder 133 #define MAYBE_CreateNewFolder DISABLED_CreateNewFolder
138 #else 134 #else
139 #define MAYBE_CreateNewFolder CreateNewFolder 135 #define MAYBE_CreateNewFolder CreateNewFolder
140 #endif 136 #endif
(...skipping 555 matching lines...) Expand 10 before | Expand all | Expand 10 after
696 692
697 IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, MAYBE_BasicDrive) { 693 IN_PROC_BROWSER_TEST_F(MultiProfileFileManagerBrowserTest, MAYBE_BasicDrive) {
698 AddAllUsers(); 694 AddAllUsers();
699 695
700 // Sanity check that normal operations work in multi-profile setting as well. 696 // Sanity check that normal operations work in multi-profile setting as well.
701 set_test_case_name("keyboardCopyDrive"); 697 set_test_case_name("keyboardCopyDrive");
702 StartTest(); 698 StartTest();
703 } 699 }
704 700
705 } // namespace file_manager 701 } // namespace file_manager
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698